From 419e787880bacf8f3c85880a57a52ac4e532430b Mon Sep 17 00:00:00 2001 From: Shehjar Tikoo Date: Thu, 2 Sep 2010 05:05:57 +0000 Subject: nfs3: Do not unref dst inode on rename cbk This gets done when the call state gets wiped. Doing it here results an extra unref causing a segfault. Signed-off-by: Shehjar Tikoo Signed-off-by: Vijay Bellur BUG: 1464 (fd leak after rename) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1464 --- xlators/nfs/server/src/nfs3.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'xlators') diff --git a/xlators/nfs/server/src/nfs3.c b/xlators/nfs/server/src/nfs3.c index 3aed70a97d5..057ccb60e25 100644 --- a/xlators/nfs/server/src/nfs3.c +++ b/xlators/nfs/server/src/nfs3.c @@ -3282,12 +3282,6 @@ nfs3svc_rename_cbk (call_frame_t *frame, void *cookie, xlator_t *this, nfs3_fdcache_remove (cs->nfs3state, openfd); } - /* This is the unref equivalent of the ref done when the inode was - * created on a lookup or a create request. - * The inode is finally unrefed in call state wipe. - */ - inode_unref (cs->resolvedloc.inode); - nfs3err: nfs3_log_common_res (nfs_rpcsvc_request_xid (cs->req), "RENAME", stat, -ret); -- cgit