From 3ec31ff213de643df27dc1f107d876315c3357ae Mon Sep 17 00:00:00 2001 From: Mohammed Rafi KC Date: Tue, 2 Aug 2016 11:59:42 +0530 Subject: meta: fix memory leak in meta xlators meta xlator is leaking iobuf and iobrefs in read path This patch fixes memleak in meta_default_read code path > Reviewed-on: http://review.gluster.org/15068 > Smoke: Gluster Build System > CentOS-regression: Gluster Build System > NetBSD-regression: NetBSD Build System > Reviewed-by: Pranith Kumar Karampuri > Reviewed-by: Poornima G BUG: 1364506 Change-Id: Ieb413267604d9870dbe6e11258fffd279a7bd7cf Signed-off-by: Mohammed Rafi KC Signed-off-by: Oleksandr Natalenko Reviewed-on: http://review.gluster.org/15102 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Prashanth Pai Reviewed-by: Pranith Kumar Karampuri --- xlators/meta/src/meta-defaults.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'xlators') diff --git a/xlators/meta/src/meta-defaults.c b/xlators/meta/src/meta-defaults.c index c34055bb221..384c0e1b205 100644 --- a/xlators/meta/src/meta-defaults.c +++ b/xlators/meta/src/meta-defaults.c @@ -153,6 +153,9 @@ meta_default_readv (call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size, return default_readv_failure_cbk (frame, ENOMEM); } + /* iobref would have taken a ref */ + iobuf_unref (iobuf); + iov.iov_base = iobuf_ptr (iobuf); copy_offset = min (meta_fd->size, offset); @@ -164,6 +167,8 @@ meta_default_readv (call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size, META_STACK_UNWIND (readv, frame, copy_size, 0, &iov, 1, &iatt, iobref, 0); + iobref_unref (iobref); + return 0; } -- cgit