From c8c56b9a53471792a126f8e46f32ce7190eac10c Mon Sep 17 00:00:00 2001 From: Kotresh HR Date: Tue, 1 Aug 2017 07:51:44 -0400 Subject: feature/posix: Enabled gfid2path by default Enable gfid2path feature by default. The basic performance tests are carried out and it doesn't show significant depreciation. The results are updated in issue. Updates: #139 Change-Id: I5f1949a608d0827018ef9d548d5d69f3bb7744fd > Signed-off-by: Kotresh HR > Reviewed-on: https://review.gluster.org/17950 > Smoke: Gluster Build System > CentOS-regression: Gluster Build System > Reviewed-by: Aravinda VK > Reviewed-by: Amar Tumballi (cherry picked from commit 3ec63650bb7fd874a5013e7be4a2def3b519c9b2) Reviewed-on: https://review.gluster.org/18133 Reviewed-by: Amar Tumballi Smoke: Gluster Build System Tested-by: Shyamsundar Ranganathan CentOS-regression: Gluster Build System Reviewed-by: Shyamsundar Ranganathan --- xlators/storage/posix/src/posix.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) (limited to 'xlators/storage/posix') diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index 188b378a58b..d858878d3e8 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -7612,18 +7612,6 @@ init (xlator_t *this) " set."); } - tmp_data = dict_get (this->options, "gfid2path"); - if (tmp_data) { - if (gf_string2boolean (tmp_data->data, - &_private->gfid2path) == -1) { - ret = -1; - gf_msg (this->name, GF_LOG_ERROR, 0, - P_MSG_INVALID_OPTION, "wrong value provided " - "for 'gfid2path'"); - goto out; - } - } - ret = dict_get_str (this->options, "glusterd-uuid", &guuid); if (!ret) { if (gf_uuid_parse (guuid, _private->glusterd_uuid)) @@ -7783,6 +7771,8 @@ init (xlator_t *this) goto out; } + GF_OPTION_INIT ("gfid2path", _private->gfid2path, bool, out); + GF_OPTION_INIT ("gfid2path-separator", gfid2path_sep, str, out); if (set_gfid2path_separator (_private, gfid2path_sep) != 0) { gf_msg (this->name, GF_LOG_ERROR, 0, P_MSG_INVALID_ARGUMENT, @@ -7977,7 +7967,7 @@ struct volume_options options[] = { }, { .key = {"gfid2path"}, .type = GF_OPTION_TYPE_BOOL, - .default_value = "off", + .default_value = "on", .description = "Enable logging metadata for gfid to path conversion" }, { .key = {"gfid2path-separator"}, -- cgit