From c097a7894d458e33a41f6db6092677108ef30fec Mon Sep 17 00:00:00 2001 From: Kotresh HR Date: Mon, 18 Jun 2018 13:40:33 -0400 Subject: ctime: Fix self heal of symlink in EC volume Since IEEE Std 1003.1-2001 does not require any association of file times with symbolic links, there is no requirement that file times be updated by readlink() states [1]. stat on symlink file was generating a readlink fop on one of the subvolumes of ec set which in turn updates atime on that subvolume. This causes mdata xattr to be different across ec set and hence self heal fails. So based on [1], atime is no longer updated by readlink fop. [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/readlink.html fixes: bz#1592509 Change-Id: I08bd3ca3bdb222bd18160b1aa58fc2f7630c8083 Signed-off-by: Kotresh HR --- xlators/storage/posix/src/posix-inode-fd-ops.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'xlators/storage/posix') diff --git a/xlators/storage/posix/src/posix-inode-fd-ops.c b/xlators/storage/posix/src/posix-inode-fd-ops.c index 714be7f7234..ccddf0ed745 100644 --- a/xlators/storage/posix/src/posix-inode-fd-ops.c +++ b/xlators/storage/posix/src/posix-inode-fd-ops.c @@ -1283,8 +1283,6 @@ posix_readlink (call_frame_t *frame, xlator_t *this, goto out; } - posix_set_ctime (frame, this, real_path, -1, loc->inode, &stbuf); - dest[op_ret] = 0; out: SET_TO_OLD_FS_ID (); -- cgit