From 0ebaa9c66347a78c3dce649e833143832114343a Mon Sep 17 00:00:00 2001 From: Bhumika Goyal Date: Sun, 19 Aug 2018 01:38:53 +0530 Subject: protocol: coverity fixes Fixes CID: 1389388 1389320 1274113 1388881 1388623 1124801 1124795 Change-Id: Ia72abc0560c959b0298f42e25abdfc5523755569 updates: bz#789278 Signed-off-by: Bhumika Goyal --- xlators/protocol/server/src/server-handshake.c | 2 -- xlators/protocol/server/src/server-rpc-fops_v2.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'xlators/protocol/server') diff --git a/xlators/protocol/server/src/server-handshake.c b/xlators/protocol/server/src/server-handshake.c index 494eafe72ea..c0b03510191 100644 --- a/xlators/protocol/server/src/server-handshake.c +++ b/xlators/protocol/server/src/server-handshake.c @@ -272,8 +272,6 @@ server_getspec (rpcsvc_request_t *req) get_checksum_for_file (spec_fd, &checksum); _volfile_update_checksum (this, key, checksum); } - } else { - op_errno = ENOENT; } if (file_len) { diff --git a/xlators/protocol/server/src/server-rpc-fops_v2.c b/xlators/protocol/server/src/server-rpc-fops_v2.c index d1b2a55131b..09d404f2d86 100644 --- a/xlators/protocol/server/src/server-rpc-fops_v2.c +++ b/xlators/protocol/server/src/server-rpc-fops_v2.c @@ -3596,6 +3596,7 @@ server4_0_zerofill(rpcsvc_request_t *req) ret = rpc_receive_common (req, &frame, &state, NULL, &args, xdr_gfx_zerofill_req, GF_FOP_ZEROFILL); if (ret != 0) { + op_errno = -1; goto out; } @@ -3611,8 +3612,6 @@ server4_0_zerofill(rpcsvc_request_t *req) resolve_and_resume (frame, server4_zerofill_resume); out: - - if (op_errno) req->rpc_err = GARBAGE_ARGS; @@ -3635,6 +3634,7 @@ server4_0_ipc (rpcsvc_request_t *req) ret = rpc_receive_common (req, &frame, &state, NULL, &args, xdr_gfx_ipc_req, GF_FOP_IPC); if (ret != 0) { + op_errno = -1; goto out; } -- cgit