From 1ec37aa78fccb45aa701a3380f6acf95819c7a39 Mon Sep 17 00:00:00 2001 From: Anand Avati Date: Sat, 28 Nov 2009 05:34:11 +0000 Subject: protocol/server: fix improper validation of fd in server_rchecksum state->fd validation should be done _after_ resolve_and_resume() Signed-off-by: Anand V. Avati Signed-off-by: Anand V. Avati BUG: 315 (generation number support) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315 --- xlators/protocol/server/src/server-protocol.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'xlators/protocol/server/src/server-protocol.c') diff --git a/xlators/protocol/server/src/server-protocol.c b/xlators/protocol/server/src/server-protocol.c index 6a085f953cf..9fc9adf14c7 100644 --- a/xlators/protocol/server/src/server-protocol.c +++ b/xlators/protocol/server/src/server-protocol.c @@ -5444,14 +5444,8 @@ server_rchecksum (call_frame_t *frame, xlator_t *bound_xl, state->offset = ntoh64 (req->offset); state->size = ntoh32 (req->len); - GF_VALIDATE_OR_GOTO(bound_xl->name, state->fd, fail); - resolve_and_resume (frame, server_rchecksum_resume); - return 0; -fail: - server_rchecksum_cbk (frame, NULL, frame->this, -1, EINVAL, 0, NULL); - return 0; } -- cgit