From 5be6f0339b5ad189868a50b837ae7b8c164a5b25 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Sat, 12 Sep 2015 19:48:06 +0530 Subject: protocol/client: Remove dead code from client_rpc_notify Normally GF_EVENT_CHILD_UP is dispatched after client handshake. But we have some dead code in client_rpc_notify which is assumed to do the same on receiving RPC_CLNT_CONNECT. This dispatch is based on a condition whether "disable-handshake" is enabled or not. Since we require client-handshake everytime we have a connect this check for "disable-handshake" is invalid and no longer required. Moreover this option is never handled in any of the translators. Change-Id: Ic862d6ac08cd3b18cf231f50140cd00e84e52ca0 BUG: 1227667 Signed-off-by: Anoop C S Reviewed-on: http://review.gluster.org/12170 Tested-by: NetBSD Build System Tested-by: Gluster Build System Reviewed-by: Krishnan Parthasarathi Reviewed-by: Raghavendra G --- xlators/protocol/client/src/client-handshake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xlators/protocol/client/src/client-handshake.c') diff --git a/xlators/protocol/client/src/client-handshake.c b/xlators/protocol/client/src/client-handshake.c index 9289859..3b170b8 100644 --- a/xlators/protocol/client/src/client-handshake.c +++ b/xlators/protocol/client/src/client-handshake.c @@ -130,7 +130,7 @@ client_notify_parents_child_up (xlator_t *this) int ret = 0; conf = this->private; - ret = client_notify_dispatch (this, GF_EVENT_CHILD_UP, NULL); + ret = client_notify_dispatch_uniq (this, GF_EVENT_CHILD_UP, NULL); if (ret) gf_msg (this->name, GF_LOG_INFO, 0, PC_MSG_CHILD_UP_NOTIFY_FAILED, "notify of CHILD_UP " -- cgit v1.1