From b832e35493aca8c49359b1db4bd7ae3afbcdd2cb Mon Sep 17 00:00:00 2001 From: Poornima G Date: Fri, 6 Mar 2015 15:16:35 +0530 Subject: Performance: Replace ASSERTS in xlator fini() with info messages, for the known leaks. There are few known leaks in read-ahead and quick-read xlator fini(). Until they are fixed replacing the ASSERTS with info, else any call to glfs_fini() in debug mode will core dump. Change-Id: Id60c6f952574863fc77c7d101cb5d5e9113090d8 BUG: 1199436 Signed-off-by: Poornima G Reviewed-on: http://review.gluster.org/9819 Reviewed-by: Raghavendra Talur Reviewed-by: Ravishankar N Reviewed-by: Raghavendra G Tested-by: Raghavendra G --- xlators/performance/quick-read/src/quick-read.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'xlators/performance/quick-read/src/quick-read.c') diff --git a/xlators/performance/quick-read/src/quick-read.c b/xlators/performance/quick-read/src/quick-read.c index 0e4ce71a571..aa44c5d388b 100644 --- a/xlators/performance/quick-read/src/quick-read.c +++ b/xlators/performance/quick-read/src/quick-read.c @@ -1049,7 +1049,13 @@ qr_inode_table_destroy (qr_private_t *priv) conf = &priv->conf; for (i = 0; i < conf->max_pri; i++) { - GF_ASSERT (list_empty (&priv->table.lru[i])); + /* There is a known leak of inodes, hence until + * that is fixed, log the assert as warning. + GF_ASSERT (list_empty (&priv->table.lru[i]));*/ + if (!list_empty (&priv->table.lru[i])) { + gf_log ("quick-read", GF_LOG_INFO, + "quick read inode table lru not empty"); + } } LOCK_DESTROY (&priv->table.lock); -- cgit