From a412a4f50d8ca2ae68dbfa93b80757889150ce99 Mon Sep 17 00:00:00 2001 From: Krutika Dhananjay Date: Tue, 20 Sep 2016 12:05:23 +0530 Subject: performance/open-behind: Pass O_DIRECT flags for anon fd reads when required Writes are already passing the correct flags at the time of open(). Also, make io-cache honor direct-io for anon-fds with O_DIRECT flag during reads. Change-Id: I215cb09ef1b607b9f95cabf0ef3065c00edd9e78 BUG: 1377556 Signed-off-by: Krutika Dhananjay Reviewed-on: http://review.gluster.org/15537 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System Reviewed-by: Raghavendra G CentOS-regression: Gluster Build System --- xlators/performance/open-behind/src/open-behind.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) (limited to 'xlators/performance/open-behind') diff --git a/xlators/performance/open-behind/src/open-behind.c b/xlators/performance/open-behind/src/open-behind.c index efab88582ff..00e8906910a 100644 --- a/xlators/performance/open-behind/src/open-behind.c +++ b/xlators/performance/open-behind/src/open-behind.c @@ -351,19 +351,25 @@ err: fd_t * -ob_get_wind_fd (xlator_t *this, fd_t *fd) +ob_get_wind_fd (xlator_t *this, fd_t *fd, uint32_t *flag) { - ob_conf_t *conf = NULL; - ob_fd_t *ob_fd = NULL; + fd_t *wind_fd = NULL; + ob_fd_t *ob_fd = NULL; + ob_conf_t *conf = NULL; conf = this->private; ob_fd = ob_fd_ctx_get (this, fd); - if (ob_fd && conf->use_anonymous_fd) - return fd_anonymous (fd->inode); + if (ob_fd && conf->use_anonymous_fd) { + wind_fd = fd_anonymous (fd->inode); + if ((ob_fd->flags & O_DIRECT) && (flag)) + *flag = *flag | O_DIRECT; + } else { + wind_fd = fd_ref (fd); + } - return fd_ref (fd); + return wind_fd; } @@ -378,7 +384,7 @@ ob_readv (call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size, conf = this->private; if (!conf->read_after_open) - wind_fd = ob_get_wind_fd (this, fd); + wind_fd = ob_get_wind_fd (this, fd, &flags); else wind_fd = fd_ref (fd); @@ -427,7 +433,7 @@ ob_fstat (call_frame_t *frame, xlator_t *this, fd_t *fd, dict_t *xdata) call_stub_t *stub = NULL; fd_t *wind_fd = NULL; - wind_fd = ob_get_wind_fd (this, fd); + wind_fd = ob_get_wind_fd (this, fd, NULL); stub = fop_fstat_stub (frame, default_fstat_resume, wind_fd, xdata); -- cgit