From 420c2d03543a35f1f5483f200541577f4a606b22 Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Sun, 19 Feb 2017 16:54:39 +0100 Subject: Fix erronous comparaison of flags Using a binary 'or' mean that we always send the UUID, even when not required. Found by coverty scan Change-Id: Ifc4bff6b2f64febd5d2f038538218c2183518fd5 BUG: 1424815 Signed-off-by: Michael Scherer Reviewed-on: https://review.gluster.org/16675 Smoke: Gluster Build System Reviewed-by: Prashanth Pai Tested-by: Shyamsundar Ranganathan NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System --- xlators/mgmt/glusterd/src/glusterd-handshake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xlators/mgmt') diff --git a/xlators/mgmt/glusterd/src/glusterd-handshake.c b/xlators/mgmt/glusterd/src/glusterd-handshake.c index 96d39f03007..bcffa5f9969 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handshake.c +++ b/xlators/mgmt/glusterd/src/glusterd-handshake.c @@ -1416,7 +1416,7 @@ __server_get_volume_info (rpcsvc_request_t *req) goto out; } - if (flags | (int32_t)GF_GET_VOLUME_UUID) { + if (flags & (int32_t)GF_GET_VOLUME_UUID) { volume_id_str = gf_strdup (uuid_utoa (volinfo->volume_id)); if (!volume_id_str) { op_errno = ENOMEM; -- cgit