From 148ed4fd15b4de78e4d16b9f41836c9a2b003246 Mon Sep 17 00:00:00 2001 From: Prasanna Kumar Kalever Date: Sat, 15 Aug 2015 01:06:32 +0530 Subject: glusterd: remove unused large memory/buffer allocations This patch cleans dead buffer allocations which are never used in the code. Change-Id: I8c55837434fd5bf9dde9fb7b070fdefbf64cf4a3 BUG: 1253828 Signed-off-by: Prasanna Kumar Kalever Reviewed-on: http://review.gluster.org/11928 Smoke: Gluster Build System CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System Reviewed-by: Atin Mukherjee --- xlators/mgmt/glusterd/src/glusterd-ganesha.c | 2 -- xlators/mgmt/glusterd/src/glusterd-snapshot.c | 2 -- xlators/mgmt/glusterd/src/glusterd-statedump.c | 1 - xlators/mgmt/glusterd/src/glusterd-store.c | 1 - xlators/mgmt/glusterd/src/glusterd-svc-mgmt.c | 1 - xlators/mgmt/glusterd/src/glusterd-volgen.c | 2 -- 6 files changed, 9 deletions(-) (limited to 'xlators/mgmt') diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c index 3f1b72c9262..ddbb7446cda 100644 --- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c +++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c @@ -224,7 +224,6 @@ glusterd_op_stage_set_ganesha (dict_t *dict, char **op_errstr) char *str = NULL; int dict_count = 0; int flags = 0; - char errstr[2048] = {0, } ; glusterd_volinfo_t *volinfo = NULL; glusterd_conf_t *priv = NULL; xlator_t *this = NULL; @@ -676,7 +675,6 @@ int start_ganesha (char **op_errstr) { int ret = -1; - char key[1024] = {0,}; char *hostname = NULL; dict_t *vol_opts = NULL; glusterd_volinfo_t *volinfo = NULL; diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c index 18ee3743f67..4e401b0f76c 100644 --- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c +++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c @@ -2828,7 +2828,6 @@ out: int32_t glusterd_lvm_snapshot_remove (dict_t *rsp_dict, glusterd_volinfo_t *snap_vol) { - struct mntent save_entry = {0,}; int32_t brick_count = -1; int32_t ret = -1; int32_t err = 0; @@ -6977,7 +6976,6 @@ glusterd_snapshot_config_commit (dict_t *dict, char **op_errstr, char *volname = NULL; xlator_t *this = NULL; int ret = -1; - char err_str[PATH_MAX] = {0,}; glusterd_conf_t *conf = NULL; int config_command = 0; uint64_t hard_limit = 0; diff --git a/xlators/mgmt/glusterd/src/glusterd-statedump.c b/xlators/mgmt/glusterd/src/glusterd-statedump.c index 228adb7292a..a01a6b8bfed 100644 --- a/xlators/mgmt/glusterd/src/glusterd-statedump.c +++ b/xlators/mgmt/glusterd/src/glusterd-statedump.c @@ -188,7 +188,6 @@ glusterd_dump_priv (xlator_t *this) int index = 1; glusterd_conf_t *priv = NULL; char key[GF_DUMP_MAX_BUF_LEN] = {0,}; - char subkey[50] = {0,}; glusterd_peerinfo_t *peerinfo = NULL; glusterd_volinfo_t *volinfo = NULL; diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c index 21cbdb8b2b9..b1f943074f3 100644 --- a/xlators/mgmt/glusterd/src/glusterd-store.c +++ b/xlators/mgmt/glusterd/src/glusterd-store.c @@ -1843,7 +1843,6 @@ glusterd_store_global_info (xlator_t *this) char path[PATH_MAX] = {0,}; gf_store_handle_t *handle = NULL; char *uuid_str = NULL; - char buf[256] = {0, }; conf = this->private; diff --git a/xlators/mgmt/glusterd/src/glusterd-svc-mgmt.c b/xlators/mgmt/glusterd/src/glusterd-svc-mgmt.c index 1238990e632..454c2a453b2 100644 --- a/xlators/mgmt/glusterd/src/glusterd-svc-mgmt.c +++ b/xlators/mgmt/glusterd/src/glusterd-svc-mgmt.c @@ -149,7 +149,6 @@ glusterd_svc_start (glusterd_svc_t *svc, int flags, dict_t *cmdline) glusterd_conf_t *priv = NULL; xlator_t *this = NULL; char valgrind_logfile[PATH_MAX] = {0}; - char glusterd_uuid_option[1024] = {0}; this = THIS; GF_ASSERT (this); diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c index b61c056507b..d3696b2a4e5 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volgen.c +++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c @@ -3612,8 +3612,6 @@ volume_volgen_graph_build_clusters (volgen_graph_t *graph, "%s-tier-%d"}; char *stripe_args[] = {"cluster/stripe", "%s-stripe-%d"}; - char *disperse_args[] = {"cluster/disperse", - "%s-disperse-%d"}; char option[32] = ""; int rclusters = 0; int clusters = 0; -- cgit