From 0f81517e2ba18f0be131fb3afa5aa333890104f2 Mon Sep 17 00:00:00 2001 From: "Kaleb S. KEITHLEY" Date: Tue, 7 Jul 2020 09:59:51 -0400 Subject: xlator/mgmt/glusterd: lto-type-mismatch Seen in fedora rawhide/33, and SUSE tumbleweed, in all versions going back at least as far as glusterfs-6. [ 351s] glusterd.c:68:13: warning: type of 'snap_mount_dir' does not match original declaration [-Wlto-type-mismatch] [ 351s] 68 | extern char snap_mount_dir[PATH_MAX]; [ 351s] | ^ [ 351s] glusterd-snapshot.c:65:6: note: array types have different bounds [ 351s] 65 | char snap_mount_dir[VALID_GLUSTERD_PATHMAX]; [ 351s] | ^ [ 351s] glusterd-snapshot.c:65:6: note: 'snap_mount_dir' was previously declared here In this case it's only a warning, but certainly merits fixing. Another case where a decl in a header file instead of open-coding extern decls in multiple .c files would have been preferable. Change-Id: Idc91e536a56a1a7717be83ed27698069e71dff67 Updates: #1002 Signed-off-by: Kaleb S. KEITHLEY --- xlators/mgmt/glusterd/src/glusterd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xlators/mgmt/glusterd/src') diff --git a/xlators/mgmt/glusterd/src/glusterd.c b/xlators/mgmt/glusterd/src/glusterd.c index 94c61542687..91c5f9ec5e3 100644 --- a/xlators/mgmt/glusterd/src/glusterd.c +++ b/xlators/mgmt/glusterd/src/glusterd.c @@ -67,7 +67,7 @@ extern struct rpcsvc_program gd_svc_cli_trusted_progs; extern struct rpc_clnt_program gd_brick_prog; extern struct rpcsvc_program glusterd_mgmt_hndsk_prog; -extern char snap_mount_dir[PATH_MAX]; +extern char snap_mount_dir[VALID_GLUSTERD_PATHMAX]; rpcsvc_cbk_program_t glusterd_cbk_prog = { .progname = "Gluster Callback", -- cgit