From 459314829691e3cb0c31f4971111d7dadfb199d8 Mon Sep 17 00:00:00 2001 From: Joseph Fernandes Date: Tue, 15 Dec 2015 14:39:25 +0530 Subject: tier/glusterd: Only positive values for freq-thresholds Fixed error handling for validation for freq-thresholds Backport of http://review.gluster.org/12970 > Change-Id: Ibe3a9752ac0b525b0c8c0d6c4b4e4d694bd91b88 > BUG: 1291603 > Signed-off-by: Joseph Fernandes > Reviewed-on: http://review.gluster.org/12970 > Reviewed-by: Dan Lambright > Tested-by: Gluster Build System > Tested-by: Dan Lambright Signed-off-by: Joseph Fernandes Change-Id: I044284b5134a685e505a377028bc9a11563b2665 BUG: 1292359 Reviewed-on: http://review.gluster.org/12992 Tested-by: Gluster Build System Tested-by: NetBSD Build System Reviewed-by: Dan Lambright Tested-by: Dan Lambright --- xlators/mgmt/glusterd/src/glusterd-volume-set.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'xlators/mgmt/glusterd/src/glusterd-volume-set.c') diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-set.c b/xlators/mgmt/glusterd/src/glusterd-volume-set.c index d6f20ab9822..403b97f9fde 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-set.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-set.c @@ -181,6 +181,7 @@ validate_tier_thresholds (glusterd_volinfo_t *volinfo, if (ret) { snprintf (errstr, sizeof (errstr), "%s is not a compatible " "value. %s expects an integer value.", value, key); + ret = -1; goto out; } @@ -188,6 +189,7 @@ validate_tier_thresholds (glusterd_volinfo_t *volinfo, snprintf (errstr, sizeof (errstr), "%s is not a " "compatible value. %s expects a positive" "integer value.", value, key); + ret = -1; goto out; } -- cgit