From 6a29c76ae629d17d276c96b2e50f0b43e5fdf309 Mon Sep 17 00:00:00 2001 From: Jiffin Tony Thottan Date: Thu, 7 Jul 2016 15:55:07 +0530 Subject: features/ganesha : remove ganesha xlator from client graph The ganesha introduced in dummy xlator in the client graph, which is used for introducing the cli options. When the volume set command "ganesha.enable" ran, this xlator will add into client graph but never removed from it. In my opinion there is no point in adding the ganesha xlator in the client graph Change-Id: I926c4b4adf991361aa459679e275cb58246c5294 BUG: 1349270 Signed-off-by: Jiffin Tony Thottan Reviewed-on: http://review.gluster.org/14871 CentOS-regression: Gluster Build System Tested-by: Gluster Build System Reviewed-by: Kaleb KEITHLEY NetBSD-regression: NetBSD Build System Smoke: Gluster Build System Reviewed-by: Atin Mukherjee --- xlators/mgmt/glusterd/src/glusterd-volgen.c | 22 ---------------------- 1 file changed, 22 deletions(-) (limited to 'xlators/mgmt/glusterd/src/glusterd-volgen.c') diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c index 699137d8f9e..1f8a0e70add 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volgen.c +++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c @@ -4198,28 +4198,6 @@ client_graph_builder (volgen_graph_t *graph, glusterd_volinfo_t *volinfo, goto out; } - ret = dict_get_str_boolean (set_dict, "ganesha.enable", _gf_false); - - if (ret == -1) { - gf_msg (this->name, GF_LOG_WARNING, errno, - GD_MSG_DICT_GET_FAILED, "setting ganesha.enable" - "option failed."); - goto out; - } - - if (ret) { - xl = volgen_graph_add (graph, "features/ganesha", volname); - - if (!xl) { - gf_msg (this->name, GF_LOG_ERROR, 0, - GD_MSG_GRAPH_FEATURE_ADD_FAIL, - "failed to add" - "add features/ganesha to graph"); - ret = -1; - goto out; - } - } - /* add debug translators depending on the options */ ret = check_and_add_debug_xl (graph, set_dict, volname, "client"); -- cgit