From 2559d959df1a5dec10b0b80ba5ac0ec292014d8e Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Mon, 13 Nov 2017 07:03:36 +0530 Subject: afr: coverity fixes 1.afr_discover_do: COPY_PASTE_ERROR 2.afr_fav_child_reset_sink_xattrs_cbk: REVERSE_INULL 3.afr_fop_lock_proceed: UNUSED_VALUE 4.afr_local_init: CHECKED_RETURN 5.afr_set_split_brain_choice: REVERSE_INULL 6.__afr_inode_write_finalize: FORWARD_NULL 7.afr_refresh_heal_done: REVERSE_INULL 8.afr_xl_op:UNUSED_VALUE 9.afr_changelog_populate_xdata: DEADCODE 10.set_afr_pending_xattrs_option: RESOURCE_LEAK Note: RESOURCE_LEAK complaints about afr_fgetxattr_pathinfo_cbk, afr_getxattr_list_node_uuids_cbk and afr_getxattr_pathinfo_cbk seem to be false alarms. Change-Id: Ia4ca1478b5e2922084732d14c1e7b1b03ad5ac45 BUG: 789278 Signed-off-by: Ravishankar N --- xlators/mgmt/glusterd/src/glusterd-volgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'xlators/mgmt/glusterd/src/glusterd-volgen.c') diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c index c07cbf396cc..6a02da17918 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volgen.c +++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c @@ -3824,7 +3824,7 @@ set_afr_pending_xattrs_option (volgen_graph_t *graph, "afr-pending-xattr", afr_xattrs_list); if (ret) - return ret; + goto out; memset (afr_xattrs_list, 0, list_size); ptr = afr_xattrs_list; i = 1; -- cgit