From 4004e667edc88ac9a8c1e9048da0919ec38be4c2 Mon Sep 17 00:00:00 2001 From: N Balachandran Date: Fri, 16 Sep 2016 13:05:59 +0530 Subject: glusterd: Revert 368e26f454fe35477e46dc698fa6b8c3c608ea8d The earlier fix prevented rebalance from starting even if only a single brick of a replica set was down. Change-Id: I8c9a7d4c1fe33f7749568357462f29796e1b832a BUG: 1376671 Signed-off-by: N Balachandran Reviewed-on: http://review.gluster.org/15517 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Raghavendra G Reviewed-by: Atin Mukherjee --- xlators/mgmt/glusterd/src/glusterd-rebalance.c | 39 -------------------------- 1 file changed, 39 deletions(-) (limited to 'xlators/mgmt/glusterd/src/glusterd-rebalance.c') diff --git a/xlators/mgmt/glusterd/src/glusterd-rebalance.c b/xlators/mgmt/glusterd/src/glusterd-rebalance.c index 9150ed24687..36a98fc87ad 100644 --- a/xlators/mgmt/glusterd/src/glusterd-rebalance.c +++ b/xlators/mgmt/glusterd/src/glusterd-rebalance.c @@ -633,8 +633,6 @@ glusterd_op_stage_rebalance (dict_t *dict, char **op_errstr) int32_t cmd = 0; char msg[2048] = {0}; glusterd_volinfo_t *volinfo = NULL; - glusterd_brickinfo_t *brickinfo = NULL; - glusterd_peerinfo_t *peerinfo = NULL; char *task_id_str = NULL; dict_t *op_ctx = NULL; xlator_t *this = 0; @@ -702,43 +700,6 @@ glusterd_op_stage_rebalance (dict_t *dict, char **op_errstr) goto out; } - cds_list_for_each_entry (brickinfo, &volinfo->bricks, - brick_list) { - if (glusterd_is_local_brick (THIS, volinfo, brickinfo)) { - if (brickinfo->status != GF_BRICK_STARTED) { - gf_asprintf (op_errstr, "Received" - " rebalance on volume with " - " stopped brick %s", - brickinfo->path); - ret = -1; - goto out; - } - } else { - rcu_read_lock (); - peerinfo = glusterd_peerinfo_find_by_uuid - (brickinfo->uuid); - if (!peerinfo) { - gf_asprintf (op_errstr, "Host node %s " - "of brick %s doesn't " - "belong to cluster", - brickinfo->hostname, - brickinfo->path); - ret = -1; - rcu_read_unlock (); - goto out; - } else if (!peerinfo->connected) { - gf_asprintf (op_errstr, "Host node %s " - "of brick %s is down", - brickinfo->hostname, - brickinfo->path); - ret = -1; - rcu_read_unlock (); - goto out; - } - rcu_read_unlock (); - } - } - case GF_DEFRAG_CMD_START_FORCE: if (is_origin_glusterd (dict)) { op_ctx = glusterd_op_get_ctx (); -- cgit