From 42b956971c47fd0708cbbd17ce8c78c2ed79bfba Mon Sep 17 00:00:00 2001 From: Vijaikumar M Date: Fri, 23 May 2014 14:42:08 +0530 Subject: glusterd: Handle rpc_connect failure in the event handler Currently rpc_connect calls the notification function on failure in the same thread, glusterd notification holds the big_lock and hence big_lock is released before rpc_connect In snapshot creation, releasing the big-lock before completeing operation can cause problem like deadlock or memory corruption. Bricks are started as part of snapshot created operation. brick_start releases the big_lock when doing brick_connect and this might cause glusterd crash. There is a similar issue in bug# 1088355. Solution is let the event handler handle the failure than doing it in the rpc_connect. Change-Id: I088d44092ce845a07516c1d67abd02b220e08b38 BUG: 1101507 Signed-off-by: Vijaikumar M Reviewed-on: http://review.gluster.org/7843 Reviewed-by: Krishnan Parthasarathi Reviewed-by: Jeff Darcy Tested-by: Gluster Build System Reviewed-by: Raghavendra G Tested-by: Raghavendra G --- xlators/mgmt/glusterd/src/glusterd-handler.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'xlators/mgmt/glusterd/src/glusterd-handler.c') diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c index 733bea236ed..e6b744af536 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handler.c +++ b/xlators/mgmt/glusterd/src/glusterd-handler.c @@ -3135,9 +3135,7 @@ glusterd_friend_add (const char *hoststr, int port, if (!restore) { ret = glusterd_store_peerinfo (*friend); if (ret == 0) { - synclock_unlock (&conf->big_lock); ret = glusterd_friend_rpc_create (this, *friend, args); - synclock_lock (&conf->big_lock); } else { gf_log (this->name, GF_LOG_ERROR, -- cgit