From 69f77d28c3ecacba77fbae2f789b5110641347f3 Mon Sep 17 00:00:00 2001 From: Poornima G Date: Wed, 27 Jun 2018 14:59:40 +0530 Subject: md-cache: Do not invalidate cache post set/remove xattr Since setxattr and removexattr fops cbk do not carry poststat, the stat cache was being invalidated in setxatr/remoxattr cbk. Hence the further lookup wouldn't be served from cache. To prevent this invalidation, md-cache is modified to get the poststat in set/removexattr_cbk in dict. Co-authored with Xavi Hernandez. Change-Id: I6b946be2d20b807e2578825743c25ba5927a60b4 fixes: bz#1586018 Signed-off-by: Xavi Hernandez Signed-off-by: Poornima G --- xlators/features/upcall/src/upcall.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'xlators/features') diff --git a/xlators/features/upcall/src/upcall.c b/xlators/features/upcall/src/upcall.c index dc09b2b3027..0bf1f413a94 100644 --- a/xlators/features/upcall/src/upcall.c +++ b/xlators/features/upcall/src/upcall.c @@ -20,7 +20,6 @@ #include "common-utils.h" #include "statedump.h" -#include "syncop.h" #include "upcall.h" #include "upcall-mem-types.h" @@ -1697,8 +1696,7 @@ up_setxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, if (!up_invalidate_needed (local->xattr)) goto out; - ret = syncop_stat (FIRST_CHILD(frame->this), &local->loc, &stbuf, - NULL, NULL); + ret = dict_get_iatt (xdata, GF_POSTSTAT, &stbuf); if (ret == 0) flags |= UP_TIMES; @@ -1774,8 +1772,7 @@ up_fsetxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, if (!up_invalidate_needed (local->xattr)) goto out; - ret = syncop_fstat (FIRST_CHILD(frame->this), local->fd, &stbuf, NULL, - NULL); + ret = dict_get_iatt (xdata, GF_POSTSTAT, &stbuf); if (ret == 0) flags |= UP_TIMES; @@ -1850,8 +1847,7 @@ up_fremovexattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, if (!up_invalidate_needed (local->xattr)) goto out; - ret = syncop_fstat (FIRST_CHILD(frame->this), local->fd, &stbuf, NULL, - NULL); + ret = dict_get_iatt (xdata, GF_POSTSTAT, &stbuf); if (ret == 0) flags |= UP_TIMES; @@ -1938,8 +1934,7 @@ up_removexattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, if (!up_invalidate_needed (local->xattr)) goto out; - ret = syncop_stat (FIRST_CHILD(frame->this), &local->loc, &stbuf, NULL, - NULL); + ret = dict_get_iatt (xdata, GF_POSTSTAT, &stbuf); if (ret == 0) flags |= UP_TIMES; -- cgit