From 28397cae4102ac3f08576ebaf071ad92683097e8 Mon Sep 17 00:00:00 2001 From: Emmanuel Dreyfus Date: Thu, 2 Apr 2015 15:51:30 +0200 Subject: Avoid conflict between contrib/uuid and system uuid glusterfs relies on Linux uuid implementation, which API is incompatible with most other systems's uuid. As a result, libglusterfs has to embed contrib/uuid, which is the Linux implementation, on non Linux systems. This implementation is incompatible with systtem's built in, but the symbols have the same names. Usually this is not a problem because when we link with -lglusterfs, libc's symbols are trumped. However there is a problem when a program not linked with -lglusterfs will dlopen() glusterfs component. In such a case, libc's uuid implementation is already loaded in the calling program, and it will be used instead of libglusterfs's implementation, causing crashes. A possible workaround is to use pre-load libglusterfs in the calling program (using LD_PRELOAD on NetBSD for instance), but such a mechanism is not portable, nor is it flexible. A much better approach is to rename libglusterfs's uuid_* functions to gf_uuid_* to avoid any possible conflict. This is what this change attempts. BUG: 1206587 Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a Signed-off-by: Emmanuel Dreyfus Reviewed-on: http://review.gluster.org/10017 Tested-by: Gluster Build System Reviewed-by: Niels de Vos --- xlators/features/qemu-block/src/qemu-block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'xlators/features/qemu-block/src/qemu-block.c') diff --git a/xlators/features/qemu-block/src/qemu-block.c b/xlators/features/qemu-block/src/qemu-block.c index 6f3d28041b9..8cc78ff165c 100644 --- a/xlators/features/qemu-block/src/qemu-block.c +++ b/xlators/features/qemu-block/src/qemu-block.c @@ -141,7 +141,7 @@ qb_format_extract (xlator_t *this, char *format, inode_t *inode) goto invalid; ret = sscanf(s, "]s", gfid_str); if (ret == 1) { - ret = uuid_parse(gfid_str, gfid); + ret = gf_uuid_parse(gfid_str, gfid); if (ret < 0) goto invalid; } @@ -164,8 +164,8 @@ qb_format_extract (xlator_t *this, char *format, inode_t *inode) * associated with a backing image as a filename local to the parent * directory. The format processing will validate further. */ - if (!uuid_is_null(gfid)) - uuid_copy(qb_inode->backing_gfid, gfid); + if (!gf_uuid_is_null(gfid)) + gf_uuid_copy(qb_inode->backing_gfid, gfid); else if (s) qb_inode->backing_fname = gf_strdup(s); -- cgit