From 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb Mon Sep 17 00:00:00 2001 From: Jeff Darcy Date: Thu, 29 Jun 2017 06:50:56 -0700 Subject: multiple: fix struct/typedef inconsistencies The most common pattern, both in our code and elsewhere, is this: struct _xyz { ... }; typedef struct _xyz xyz_t; These exceptions - especially call_frame/call_stack - have been slowing down code navigation for years. By converging on a single pattern, navigating from xyz_t in code to the actual definition of struct _xyz (i.e. without having to visit the typedef first) might even be automatable. Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed Signed-off-by: Jeff Darcy Reviewed-on: https://review.gluster.org/17650 Smoke: Gluster Build System Tested-by: Jeff Darcy CentOS-regression: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Niels de Vos --- xlators/features/locks/src/locks.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'xlators/features/locks') diff --git a/xlators/features/locks/src/locks.h b/xlators/features/locks/src/locks.h index 8eb35da44be..3d3b327f56c 100644 --- a/xlators/features/locks/src/locks.h +++ b/xlators/features/locks/src/locks.h @@ -100,14 +100,14 @@ struct __pl_inode_lock { }; typedef struct __pl_inode_lock pl_inode_lock_t; -struct __pl_rw_req_t { +struct _pl_rw_req { struct list_head list; call_stub_t *stub; posix_lock_t region; }; -typedef struct __pl_rw_req_t pl_rw_req_t; +typedef struct _pl_rw_req pl_rw_req_t; -struct __pl_dom_list_t { +struct _pl_dom_list { struct list_head inode_list; /* list_head back to pl_inode_t */ const char *domain; struct list_head entrylk_list; /* List of entry locks */ @@ -115,7 +115,7 @@ struct __pl_dom_list_t { struct list_head inodelk_list; /* List of inode locks */ struct list_head blocked_inodelks; /* List of all blocked inodelks */ }; -typedef struct __pl_dom_list_t pl_dom_list_t; +typedef struct _pl_dom_list pl_dom_list_t; struct __entry_lock { struct list_head domain_list; /* list_head back to pl_dom_list_t */ -- cgit