From 42a508fb008c4d2d90faf30616423cfbcba84a30 Mon Sep 17 00:00:00 2001 From: Joseph Fernandes Date: Thu, 9 Apr 2015 15:07:54 +0530 Subject: ctr/libgfdb: Performance enhancer for unlink/create/rename/link fops 1) ctr_link_consistency option for ctr xaltor is provided so that the user can choose to switch it on or off. /* For link consistency we do a double update i.e mark the link * during the wind and during the unwind we update/delete the link. * This has a performance hit. We give a choice here whether we need * link consistency to be spoton or not using link_consistency flag. * This will have only one link update */ 2) In delete the wind time recording is moved to unwind path. /* Special performance case: * Updating wind time in unwind for delete. This is done here * as in the wind path we will not know whether its the last * link or not. For a last link there is not use to update any * wind or unwind time!*/ > http://review.gluster.org/#/c/10170/ > Cherry picked from commit 606d9734543208542afcf9df982bf2d560235ef6 > Change-Id: I209472fb816f939db4a868b97ba053b028f17ea6 > BUG: 1217786 > Signed-off-by: Joseph Fernandes > Reviewed-on: http://review.gluster.org/10170 > Reviewed-by: Dan Lambright > Tested-by: Gluster Build System > Signed-off-by: Joseph Fernandes Change-Id: I4a89ef80875f36cff91520f712e1f47fde258a63 BUG: 1219066 Signed-off-by: Joseph Fernandes Reviewed-on: http://review.gluster.org/10170 Reviewed-by: Dan Lambright Tested-by: Gluster Build System Signed-off-by: Joseph Fernandes Reviewed-on: http://review.gluster.org/10614 Tested-by: NetBSD Build System Reviewed-by: Vijay Bellur --- xlators/features/changetimerecorder/src/changetimerecorder.c | 8 ++++++++ xlators/features/changetimerecorder/src/ctr-helper.c | 5 +++++ xlators/features/changetimerecorder/src/ctr-helper.h | 2 ++ 3 files changed, 15 insertions(+) (limited to 'xlators/features/changetimerecorder') diff --git a/xlators/features/changetimerecorder/src/changetimerecorder.c b/xlators/features/changetimerecorder/src/changetimerecorder.c index 42470a92ef9..fd57a445e08 100644 --- a/xlators/features/changetimerecorder/src/changetimerecorder.c +++ b/xlators/features/changetimerecorder/src/changetimerecorder.c @@ -958,6 +958,9 @@ reconfigure (xlator_t *this, dict_t *options) GF_OPTION_RECONF ("record-counters", _priv->ctr_record_counter, options, bool, out); + GF_OPTION_RECONF ("ctr_link_consistency", _priv->ctr_link_consistency, + options, bool, out); + GF_OPTION_RECONF ("record-exit", _priv->ctr_record_unwind, options, bool, out); @@ -1154,6 +1157,11 @@ struct volume_options options[] = { .value = {"on", "off"}, .default_value = "off" }, + { .key = {"ctr_link_consistency"}, + .type = GF_OPTION_TYPE_BOOL, + .value = {"on", "off"}, + .default_value = "off" + }, { .key = {"hot-brick"}, .type = GF_OPTION_TYPE_BOOL, .value = {"on", "off"}, diff --git a/xlators/features/changetimerecorder/src/ctr-helper.c b/xlators/features/changetimerecorder/src/ctr-helper.c index da5a3deed96..a2e2569818d 100644 --- a/xlators/features/changetimerecorder/src/ctr-helper.c +++ b/xlators/features/changetimerecorder/src/ctr-helper.c @@ -97,6 +97,7 @@ fill_db_record_for_wind (xlator_t *this, ctr_wtime = &CTR_DB_REC(ctr_local).gfdb_wind_change_time; CTR_DB_REC(ctr_local).gfdb_fop_path = ctr_inode_cx->fop_path; CTR_DB_REC(ctr_local).gfdb_fop_type = ctr_inode_cx->fop_type; + CTR_DB_REC(ctr_local).link_consistency = _priv->ctr_link_consistency; ret = gettimeofday (ctr_wtime, NULL); if (ret) { @@ -265,6 +266,10 @@ int extract_ctr_options (xlator_t *this, gf_ctr_private_t *_priv) { GF_OPTION_INIT ("record-counters", _priv->ctr_record_counter, bool, out); + /*Extract flag for link consistency*/ + GF_OPTION_INIT ("ctr_link_consistency", _priv->ctr_link_consistency, + bool, out); + /*Extract flag for hot tier brick*/ GF_OPTION_INIT ("hot-brick", _priv->ctr_hot_brick, bool, out); diff --git a/xlators/features/changetimerecorder/src/ctr-helper.h b/xlators/features/changetimerecorder/src/ctr-helper.h index 6f4ad5cbe7a..85ee872fa33 100644 --- a/xlators/features/changetimerecorder/src/ctr-helper.h +++ b/xlators/features/changetimerecorder/src/ctr-helper.h @@ -37,6 +37,7 @@ typedef struct gf_ctr_private { gf_boolean_t ctr_record_wind; gf_boolean_t ctr_record_unwind; gf_boolean_t ctr_record_counter; + gf_boolean_t ctr_link_consistency; gfdb_db_type_t gfdb_db_type; gfdb_sync_type_t gfdb_sync_type; gfdb_conn_node_t *_db_conn; @@ -380,6 +381,7 @@ ctr_insert_wind (call_frame_t *frame, "WIND: Error filling ctr local"); goto out; } + /*Insert the db record*/ ret = insert_record (_priv->_db_conn, &ctr_local->gfdb_db_record); -- cgit