From d5918849bebc8df85b017e3eddefaef69f008889 Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Sat, 3 May 2014 16:17:04 -0700 Subject: changelog: in C99 `inline` shouldn't be part of function definition - C99 standard dictates that `inline` should be used only to hint function implementation not as a definition - http://clang.llvm.org/compatibility.html#inline This also leads to run time issues as 'undefined symbols' - Remember to use adding explicit headers when using an external function Change-Id: I66a9030da7ac38ded6e0b6a977182be977382fa2 BUG: 1089172 Signed-off-by: Harshavardhana Reviewed-on: http://review.gluster.org/7655 Reviewed-by: Anand Avati Tested-by: Anand Avati --- xlators/features/changelog/src/changelog-helpers.h | 10 +++++----- xlators/features/changelog/src/changelog.c | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) (limited to 'xlators/features/changelog/src') diff --git a/xlators/features/changelog/src/changelog-helpers.h b/xlators/features/changelog/src/changelog-helpers.h index 8e591e2f935..ec90f8a13d7 100644 --- a/xlators/features/changelog/src/changelog-helpers.h +++ b/xlators/features/changelog/src/changelog-helpers.h @@ -395,18 +395,18 @@ int changelog_forget (xlator_t *this, inode_t *inode); /* Geo-Rep snapshot dependency changes */ -inline void +void changelog_color_fop_and_inc_cnt (xlator_t *this, changelog_priv_t *priv, changelog_local_t *local); -inline void +void changelog_inc_fop_cnt (xlator_t *this, changelog_priv_t *priv, changelog_local_t *local); -inline void +void changelog_dec_fop_cnt (xlator_t *this, changelog_priv_t *priv, changelog_local_t *local); -inline int +int changelog_barrier_notify (changelog_priv_t *priv, char* buf); -inline void +void changelog_barrier_cleanup (xlator_t *this, changelog_priv_t *priv, struct list_head *queue); void diff --git a/xlators/features/changelog/src/changelog.c b/xlators/features/changelog/src/changelog.c index 1253a1a6829..5eb2cd93fd3 100644 --- a/xlators/features/changelog/src/changelog.c +++ b/xlators/features/changelog/src/changelog.c @@ -19,6 +19,7 @@ #include "iobuf.h" #include "changelog-rt.h" +#include "changelog-helpers.h" #include "changelog-encoders.h" #include "changelog-mem-types.h" -- cgit