From eeb356584897ff778ffcbacff1c71d35d277b726 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Fri, 29 May 2015 16:33:09 +0530 Subject: features/changelog: Remove inline keyword to avoid warnings (gcc v5.1.1) When compiled with gcc5, following warnings were displayed and volume start failed: changelog-helpers.h:499:1: warning: inline function 'changelog_dispatch_event' declared but never defined changelog_dispatch_event (xlator_t *, changelog_priv_t *, changelog_event_t *); gf-changelog-journal-handler.c:692:17: warning: 'list_add_tail' is static but used in inline function 'gf_changelog_queue_journal' which is not static list_add_tail (&entry->list, &jnl_proc->entries); Fix is to remove the keyword from function prototype and definitions. Change-Id: I188b35b7ca087a94d7a48a052b05a6d845e3b74b BUG: 1226307 Signed-off-by: Anoop C S Reviewed-on: http://review.gluster.org/11004 Tested-by: NetBSD Build System Reviewed-by: Venky Shankar --- xlators/features/changelog/lib/src/gf-changelog-journal-handler.c | 2 +- xlators/features/changelog/lib/src/gf-changelog-reborp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'xlators/features/changelog/lib/src') diff --git a/xlators/features/changelog/lib/src/gf-changelog-journal-handler.c b/xlators/features/changelog/lib/src/gf-changelog-journal-handler.c index e5bc38f865d..2975b06757f 100644 --- a/xlators/features/changelog/lib/src/gf-changelog-journal-handler.c +++ b/xlators/features/changelog/lib/src/gf-changelog-journal-handler.c @@ -671,7 +671,7 @@ gf_changelog_process (void *data) return NULL; } -inline void +void gf_changelog_queue_journal (gf_changelog_processor_t *jnl_proc, changelog_event_t *event) { diff --git a/xlators/features/changelog/lib/src/gf-changelog-reborp.c b/xlators/features/changelog/lib/src/gf-changelog-reborp.c index 457d829e69b..2a1e56ae79e 100644 --- a/xlators/features/changelog/lib/src/gf-changelog-reborp.c +++ b/xlators/features/changelog/lib/src/gf-changelog-reborp.c @@ -197,7 +197,7 @@ gf_changelog_reborp_init_rpc_listner (xlator_t *this, * * @FIXME: cleanup this bugger once server filters events. */ -inline void +void gf_changelog_invoke_callback (gf_changelog_t *entry, struct iovec **vec, int payloadcnt) { @@ -236,7 +236,7 @@ __is_expected_sequence (struct gf_event_list *ev, struct gf_event *event) return (ev->next_seq == event->seq); } -inline int +int __can_process_event (struct gf_event_list *ev, struct gf_event **event) { *event = list_first_entry (&ev->events, struct gf_event, list); -- cgit