From e62c0fe19b113d42db5e0f80fa7cbb82f2f88190 Mon Sep 17 00:00:00 2001 From: Kaleb S KEITHLEY Date: Fri, 18 Dec 2015 07:44:45 -0500 Subject: build: export minimum symbols from xlators for correct resolution Revisiting http://review.gluster.org/#/c/11814/, which unintentionally introduced warnings from libtool about the xlator .so names. According to [1], the -module option must appear in the Makefile.am file(s); if -module is defined in a macro, e.g. in configure(.ac), then libtool will not recognize that this is a module and will emit a warning. [1] http://www.gnu.org/software/automake/manual/automake.html#Libtool-Modules Change-Id: Ifa5f9327d18d139597791c305aa10cc4410fb078 BUG: 1248669 Signed-off-by: Kaleb S KEITHLEY Reviewed-on: http://review.gluster.org/13003 Tested-by: NetBSD Build System Tested-by: Gluster Build System Reviewed-by: soumya k Reviewed-by: Niels de Vos --- xlators/encryption/crypt/src/Makefile.am | 2 +- xlators/encryption/rot-13/src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'xlators/encryption') diff --git a/xlators/encryption/crypt/src/Makefile.am b/xlators/encryption/crypt/src/Makefile.am index 050d6cca7b3..5e45a5da98a 100644 --- a/xlators/encryption/crypt/src/Makefile.am +++ b/xlators/encryption/crypt/src/Makefile.am @@ -3,7 +3,7 @@ if ENABLE_CRYPT_XLATOR xlator_LTLIBRARIES = crypt.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/encryption -crypt_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +crypt_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) crypt_la_SOURCES = keys.c data.c metadata.c atom.c crypt.c crypt_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la -lssl -lcrypto diff --git a/xlators/encryption/rot-13/src/Makefile.am b/xlators/encryption/rot-13/src/Makefile.am index a6213c0b690..cc4b7c13005 100644 --- a/xlators/encryption/rot-13/src/Makefile.am +++ b/xlators/encryption/rot-13/src/Makefile.am @@ -1,7 +1,7 @@ xlator_LTLIBRARIES = rot-13.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/encryption -rot_13_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +rot_13_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) rot_13_la_SOURCES = rot-13.c rot_13_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la -- cgit