From 2a3adcfe5c8d649a17b2d30f3715f26794dff6bb Mon Sep 17 00:00:00 2001 From: Csaba Henk Date: Sun, 29 Nov 2009 19:26:57 +0000 Subject: fix leaks pointed out by cppcheck static analyzer See http://cppcheck.sf.net [./build/libglusterfs/src/y.tab.c:2104]: (error) Memory leak: cmd [./libglusterfs/src/md5.c:306]: (error) Resource leak: f [./xlators/debug/io-stats/src/io-stats.c:1396]: (error) Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 1402 [./xlators/cluster/stripe/src/stripe.c:3597]: (error) Memory leak: dup_str [./xlators/debug/trace/src/trace.c:2426]: (error) Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 2429 These appear in rarely hit error cases or test/demo code so nothing serious, in fact. Signed-off-by: Csaba Henk Signed-off-by: Anand V. Avati BUG: 420 (fix leaks pointed out by cppcheck static analyzer) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=420 --- xlators/debug/trace/src/trace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'xlators/debug/trace') diff --git a/xlators/debug/trace/src/trace.c b/xlators/debug/trace/src/trace.c index 6fe27c635f9..b4fcf29e1e4 100644 --- a/xlators/debug/trace/src/trace.c +++ b/xlators/debug/trace/src/trace.c @@ -2423,7 +2423,7 @@ process_call_list (const char *list, int include) int32_t init (xlator_t *this) { - dict_t *options = this->options; + dict_t *options = NULL; char *includes = NULL, *excludes = NULL; if (!this) @@ -2440,6 +2440,7 @@ init (xlator_t *this) } + options = this->options; includes = data_to_str (dict_get (options, "include-ops")); excludes = data_to_str (dict_get (options, "exclude-ops")); -- cgit