From 497d9f7d51443f4f463ca00f4fdddc42c6464e0f Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Tue, 7 Jan 2020 12:57:29 +0200 Subject: dht-rename.c: fix Coverity issues 1397018/7 - strcat into uninitialized value initialize both src and dst if they were not initialized already. fixes: CID#1397018 Change-Id: Ic91954423953e8bf24eaa11fc2798c554f304d28 updates: bz#1193929 Signed-off-by: Yaniv Kaul --- xlators/cluster/dht/src/dht-rename.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'xlators/cluster/dht/src') diff --git a/xlators/cluster/dht/src/dht-rename.c b/xlators/cluster/dht/src/dht-rename.c index f6a530f8357..d9dbf50492f 100644 --- a/xlators/cluster/dht/src/dht-rename.c +++ b/xlators/cluster/dht/src/dht-rename.c @@ -503,6 +503,8 @@ dht_order_rename_lock(call_frame_t *frame, loc_t **loc, xlator_t **subvol) uuid_utoa_r(local->loc.pargfid, src); else if (local->loc.parent) uuid_utoa_r(local->loc.parent->gfid, src); + else + src[0] = '\0'; strcat(src, local->loc.name); @@ -518,6 +520,8 @@ dht_order_rename_lock(call_frame_t *frame, loc_t **loc, xlator_t **subvol) uuid_utoa_r(local->loc2.pargfid, dst); else if (local->loc2.parent) uuid_utoa_r(local->loc2.parent->gfid, dst); + else + dst[0] = '\0'; strcat(dst, local->loc2.name); ret = strcmp(src, dst); -- cgit