From d68e426263708334945dff69b88218ed71a48033 Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Sat, 8 Jun 2019 01:22:27 +0300 Subject: Multiple files: get trivial stuff done before lock Initialize a dictionary for example seems to be prefectly fine to be done before taking a lock. Change-Id: Ib29516c4efa8f0e2b526d512beab488fcd16d2e7 updates: bz#1193929 Signed-off-by: Yaniv Kaul --- xlators/cluster/afr/src/afr-common.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'xlators/cluster/afr') diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c index bce0af5791a..a1d9148915b 100644 --- a/xlators/cluster/afr/src/afr-common.c +++ b/xlators/cluster/afr/src/afr-common.c @@ -5052,20 +5052,18 @@ __afr_launch_notify_timer(xlator_t *this, afr_private_t *priv) } } -int +static int __get_heard_from_all_status(xlator_t *this) { afr_private_t *priv = this->private; - int heard_from_all = 1; - int i = 0; + int i; for (i = 0; i < priv->child_count; i++) { if (!priv->last_event[i]) { - heard_from_all = 0; - break; + return 0; } } - return heard_from_all; + return 1; } static int -- cgit