From 840bc1209c942f110037065ece4a52dce04d36c5 Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Wed, 1 Jun 2016 17:57:41 +0530 Subject: afr: Consider ENOSPC and EDQUOT as symmetric errors Backport of http://review.gluster.org/#/c/14604/ Problem: Since commit 8eaa3506ead4f11b81b146a9e56575c79f3aad7b, in replica 3, if a brick is down and a create fails on the other 2 brick with EDQUOT, we consider it an unsymmetric error and hence do not do post-op. So the dirty xattr remains set on the parent dir, leading to conservative merges during heal when all bricks are up. i.e. a file deleted on the source might re-appear after heal. Fix: Consider ENOSPC and EDQUOT as symmetric errors since there is no possibility of partial inode or entry modification operations possible when quota is enabled. IOW, if quota reports EDQUOT, the no. of bytes written (or not written) will be the same on all bricks of the replica. Likewise, the entry operation (create, mkdir...) will either succeed or not succeed on all bricks. Change-Id: Iacb1108e9ef4a918e36242fb4a957455133744e9 BUG: 1344561 Signed-off-by: Ravishankar N Reviewed-on: http://review.gluster.org/14688 Smoke: Gluster Build System CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System Reviewed-by: Pranith Kumar Karampuri --- xlators/cluster/afr/src/afr-transaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'xlators/cluster/afr') diff --git a/xlators/cluster/afr/src/afr-transaction.c b/xlators/cluster/afr/src/afr-transaction.c index 994aae18204..ea1f38652d1 100644 --- a/xlators/cluster/afr/src/afr-transaction.c +++ b/xlators/cluster/afr/src/afr-transaction.c @@ -640,14 +640,10 @@ afr_handle_symmetric_errors (call_frame_t *frame, xlator_t *this) } i_errno = local->replies[i].op_errno; - if (i_errno == ENOTCONN || i_errno == EDQUOT || - i_errno == ENOSPC) { + if (i_errno == ENOTCONN) { /* ENOTCONN is not a symmetric error. We do not know if the operation was performed on the backend or not. - * Before reaching EDQUOT and ENOSPC, each brick would - * have written some amount of data, hence this is not - * symmetric error. */ matching_errors = _gf_false; break; -- cgit