From 0299f7f0f7c4d8e5e7e04d8bc1787ecbee6dbe52 Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Fri, 19 Dec 2014 16:38:43 +0530 Subject: afr: coverity fixes Some fixes for the 17th Dec 2014 run. https://scan6.coverity.com:8443/reports.htm#v31028/p10714/g31029 Change-Id: Ia4410ef87a56fffb61803d0a4e62369b058e1cfb BUG: 1176089 Signed-off-by: Ravishankar N Reviewed-on: http://review.gluster.org/9314 Tested-by: Gluster Build System Reviewed-by: Pranith Kumar Karampuri Tested-by: Pranith Kumar Karampuri --- xlators/cluster/afr/src/pump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'xlators/cluster/afr/src/pump.c') diff --git a/xlators/cluster/afr/src/pump.c b/xlators/cluster/afr/src/pump.c index c6923fa45ac..747b5ba2592 100644 --- a/xlators/cluster/afr/src/pump.c +++ b/xlators/cluster/afr/src/pump.c @@ -1429,6 +1429,7 @@ pump_getxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, strlen (AFR_XATTR_PREFIX))) { op_errno = ENODATA; + ret = -1; goto out; } @@ -1436,14 +1437,12 @@ pump_getxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, gf_log (this->name, GF_LOG_DEBUG, "Hit pump command - status"); pump_execute_status (frame, this); - ret = 0; goto out; } } afr_getxattr (frame, this, loc, name, xdata); - ret = 0; out: if (ret < 0) AFR_STACK_UNWIND (getxattr, frame, -1, op_errno, NULL, NULL); -- cgit