From e7b79c59590c203c65f7ac8548b30d068c232d33 Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Wed, 28 Feb 2018 17:58:31 +0530 Subject: cluster/afr: Fix dict-leak in pre-op At the time of pre-op, pre_op_xdata is populted with the xattrs we get from the disk and at the time of post-op it gets over-written without unreffing the previous value stored leading to a leak. This is a regression we missed in https://review.gluster.org/#/q/ba149bac92d169ae2256dbc75202dc9e5d06538e BUG: 1550078 Change-Id: I0456f9ad6f77ce6248b747964a037193af3a3da7 Signed-off-by: Pranith Kumar K --- xlators/cluster/afr/src/afr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xlators/cluster/afr/src/afr.h') diff --git a/xlators/cluster/afr/src/afr.h b/xlators/cluster/afr/src/afr.h index 9f4e34a2afa..fdda295718c 100644 --- a/xlators/cluster/afr/src/afr.h +++ b/xlators/cluster/afr/src/afr.h @@ -749,8 +749,8 @@ typedef struct _afr_local { unsigned char *pre_op; - /* For arbiter configuration only. */ - dict_t **pre_op_xdata; + /* Changelog xattr dict for [f]xattrop*/ + dict_t **changelog_xdata; unsigned char *pre_op_sources; /* @failed_subvols: subvolumes on which a pre-op or a -- cgit