From 2f15ffd6b5beef9abd501c594bc3cb38c2683f77 Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Fri, 2 Jul 2010 04:55:28 +0000 Subject: NULL dereference fixes in code base after running with 'clang' * 212 logical (NULL deref/divide by zero) errors reduced to 28 (27 of them in contrib/ and lex part of codebase, 1 is invalid) * 11 API errors reduced to 0 Signed-off-by: Amar Tumballi Signed-off-by: Anand V. Avati BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966 --- xlators/cluster/afr/src/afr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'xlators/cluster/afr/src/afr.c') diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c index 718384717e4..4ae128bbb55 100644 --- a/xlators/cluster/afr/src/afr.c +++ b/xlators/cluster/afr/src/afr.c @@ -2744,7 +2744,7 @@ init (xlator_t *this) int32_t background_count = 0; int32_t lock_server_count = 1; - int32_t window_size; + int32_t window_size = 0; int fav_ret = -1; int read_ret = -1; @@ -2780,8 +2780,8 @@ init (xlator_t *this) &background_count); if (dict_ret == 0) { gf_log (this->name, GF_LOG_DEBUG, - "Setting background self-heal count to %d.", - window_size); + "Setting background self-heal count to %d", + background_count); priv->background_self_heal_count = background_count; } @@ -2819,7 +2819,7 @@ init (xlator_t *this) &window_size); if (dict_ret == 0) { gf_log (this->name, GF_LOG_DEBUG, - "Setting data self-heal window size to %d.", + "Setting data self-heal window size to %d", window_size); priv->data_self_heal_window_size = window_size; -- cgit