From 0a012d82717562896831c12103f91839f6269259 Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Fri, 27 May 2016 15:47:07 +0530 Subject: cluster/afr: Unwind xdata_rsp even in case of failures DHT expects GF_PREOP_CHECK_FAILED to be present in xdata_rsp in case of mkdir failures because of stale layout. But AFR was unwinding null xdata_rsp in case of failures. This was leading to mkdir failures just after remove-brick. Unwind the xdata_rsp in case of failures to make sure the response from brick reaches dht. >BUG: 1340623 >Change-Id: Idd3f7b95730e8ea987b608e892011ff190e181d1 >Signed-off-by: Pranith Kumar K >Reviewed-on: http://review.gluster.org/14553 >NetBSD-regression: NetBSD Build System >Reviewed-by: Ravishankar N >Smoke: Gluster Build System >CentOS-regression: Gluster Build System >Reviewed-by: Anuradha Talur >Reviewed-by: Krutika Dhananjay BUG: 1340992 Change-Id: I2641d35a851be692aa223dfea5d082245ac6c2bc Signed-off-by: Pranith Kumar K Reviewed-on: http://review.gluster.org/14633 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Smoke: Gluster Build System --- xlators/cluster/afr/src/afr-transaction.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'xlators/cluster/afr/src/afr-transaction.h') diff --git a/xlators/cluster/afr/src/afr-transaction.h b/xlators/cluster/afr/src/afr-transaction.h index c58531eff44..ca8fcfefa89 100644 --- a/xlators/cluster/afr/src/afr-transaction.h +++ b/xlators/cluster/afr/src/afr-transaction.h @@ -55,4 +55,8 @@ gf_boolean_t afr_has_quorum (unsigned char *subvols, xlator_t *this); gf_boolean_t afr_needs_changelog_update (afr_local_t *local); void afr_zero_fill_stat (afr_local_t *local); +void +afr_pick_error_xdata (afr_local_t *local, afr_private_t *priv, + inode_t *inode1, unsigned char *readable1, + inode_t *inode2, unsigned char *readable2); #endif /* __TRANSACTION_H__ */ -- cgit