From b2a5eed9b17a82ec4b6366b0107fe2271328c16a Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Mon, 28 Mar 2016 16:31:12 +0530 Subject: cluster/afr: Don't lookup/forget inodes Problem: All inodes that are looked-up are always forgotten without fail in afr removing the benefits of them being in lru. This same code can cause crashes if between inode_lookup, inode_forget in afr if the top xlator does inode_forget(0). Fix: Don't use lookup/forget in afr. No benefits are there at the moment for keeping this code. It is impossible to prevent top xlators to do inode_forget(0). Found similar instances in ec and removed them even though those code paths are not going to be executed in any place other than heal-daemon. BUG: 1321554 Change-Id: Ia4cb236178f7f129cc898d53f0bbd26f494a2a8d Signed-off-by: Pranith Kumar K Reviewed-on: http://review.gluster.org/13834 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Anuradha Talur --- xlators/cluster/afr/src/afr-self-heal.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'xlators/cluster/afr/src/afr-self-heal.h') diff --git a/xlators/cluster/afr/src/afr-self-heal.h b/xlators/cluster/afr/src/afr-self-heal.h index b0f545f2816..0bee7a023ad 100644 --- a/xlators/cluster/afr/src/afr-self-heal.h +++ b/xlators/cluster/afr/src/afr-self-heal.h @@ -189,9 +189,6 @@ afr_selfheal_newentry_mark (call_frame_t *frame, xlator_t *this, inode_t *inode, int source, struct afr_reply *replies, unsigned char *sources, unsigned char *newentry); -inode_t* -afr_inode_link (inode_t *inode, struct iatt *iatt); - unsigned int afr_success_count (struct afr_reply *replies, unsigned int count); -- cgit