From b3df5abbb7ab4d0f5015da9e4d5ecea79eed9b98 Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Thu, 19 Sep 2019 20:52:46 +0300 Subject: afr: replace afr_frame_return() when possible with direct call If you are already under lock, just decrement the call count directly instead of removing the lock, re-taking the lock and decrementing. Implements https://github.com/gluster/glusterfs/issues/728 updates: bz#1193929 Signed-off-by: Yaniv Kaul Change-Id: I3fa20b4651fbdb826655c5a03baeed46e99b5487 --- xlators/cluster/afr/src/afr-open.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'xlators/cluster/afr/src/afr-open.c') diff --git a/xlators/cluster/afr/src/afr-open.c b/xlators/cluster/afr/src/afr-open.c index 1747a079fa6..d262c35f1a2 100644 --- a/xlators/cluster/afr/src/afr-open.c +++ b/xlators/cluster/afr/src/afr-open.c @@ -78,11 +78,10 @@ afr_open_cbk(call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, if (!local->xdata_rsp && xdata) local->xdata_rsp = dict_ref(xdata); } + call_count = --local->call_count; } UNLOCK(&frame->lock); - call_count = afr_frame_return(frame); - if (call_count == 0) { afr_handle_replies_quorum(frame, this); if (local->op_ret == -1) { -- cgit