From f4a391e5a44950b0468af082255b9f5abf52b10b Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Fri, 16 May 2014 15:41:33 +0530 Subject: cluster/afr: move messages to new logging framework Change important (from a diagnostics point of view) log messages to use the gf_msg() framework. Change-Id: I0a58184bbb78989db149e67f07c140a21c781bc2 BUG: 1075611 Signed-off-by: Ravishankar N Reviewed-on: http://review.gluster.org/7784 Reviewed-by: Krutika Dhananjay Tested-by: Gluster Build System Reviewed-by: Pranith Kumar Karampuri Tested-by: Pranith Kumar Karampuri --- xlators/cluster/afr/src/afr-messages.h | 61 ++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 xlators/cluster/afr/src/afr-messages.h (limited to 'xlators/cluster/afr/src/afr-messages.h') diff --git a/xlators/cluster/afr/src/afr-messages.h b/xlators/cluster/afr/src/afr-messages.h new file mode 100644 index 00000000000..a076161aa9c --- /dev/null +++ b/xlators/cluster/afr/src/afr-messages.h @@ -0,0 +1,61 @@ +/* + Copyright (c) 2014 Red Hat, Inc. + This file is part of GlusterFS. + + This file is licensed to you under your choice of the GNU Lesser + General Public License, version 3 or any later version (LGPLv3 or + later), or the GNU General Public License, version 2 (GPLv2), in all + cases as published by the Free Software Foundation. + */ + +#ifndef _AFR_MESSAGES_H_ +#define _AFR_MESSAGES_H_ + +#ifndef _CONFIG_H +#define _CONFIG_H +#include "config.h" +#endif + +#include "glfs-message-id.h" + +/* NOTE: Rules for message additions + * 1) Each instance of a message is _better_ left with a unique message ID, even + * if the message format is the same. Reasoning is that, if the message + * format needs to change in one instance, the other instances are not + * impacted or the new change does not change the ID of the instance being + * modified. + * 2) Addition of a message, + * - Should increment the GLFS_NUM_MESSAGES + * - Append to the list of messages defined, towards the end + * - Retain macro naming as glfs_msg_X (for redability across developers) + * NOTE: Rules for message format modifications + * 3) Check acorss the code if the message ID macro in question is reused + * anywhere. If reused then then the modifications should ensure correctness + * everywhere, or needs a new message ID as (1) above was not adhered to. If + * not used anywhere, proceed with the required modification. + * NOTE: Rules for message deletion + * 4) Check (3) and if used anywhere else, then cannot be deleted. If not used + * anywhere, then can be deleted, but will leave a hole by design, as + * addition rules specify modification to the end of the list and not filling + * holes. + */ + +#define GLFS_COMP_BASE_AFR GLFS_MSGID_COMP_AFR +#define GLFS_NUM_MESSAGES 9 +#define GLFS_MSGID_END (GLFS_COMP_BASE_AFR + GLFS_NUM_MESSAGES + 1) + +#define glfs_msg_start_x GLFS_COMP_BASE_AFR, "Invalid: Start of messages" + +#define AFR_MSG_QUORUM_FAIL (GLFS_COMP_BASE_AFR + 1) +#define AFR_MSG_QUORUM_MET (GLFS_COMP_BASE_AFR + 2) +#define AFR_MSG_QUORUM_OVERRIDE (GLFS_COMP_BASE_AFR + 3) +#define AFR_MSG_INVALID_CHILD_UP (GLFS_COMP_BASE_AFR + 4) +#define AFR_MSG_SUBVOL_UP (GLFS_COMP_BASE_AFR + 5) +#define AFR_MSG_ALL_SUBVOLS_DOWN (GLFS_COMP_BASE_AFR + 6) +#define AFR_MSG_ENTRY_UNLOCK_FAIL (GLFS_COMP_BASE_AFR + 7) +#define AFR_MSG_SPLIT_BRAIN (GLFS_COMP_BASE_AFR + 8) +#define AFR_MSG_OPEN_FAIL (GLFS_COMP_BASE_AFR + 9) + +#define glfs_msg_end_x GLFS_MSGID_END, "Invalid: End of messages" + +#endif /* !_AFR_MESSAGES_H_ */ -- cgit