From b1246773d17fadf93abb54c2fd504b3fc31944a9 Mon Sep 17 00:00:00 2001 From: Vikas Gorur Date: Tue, 8 Sep 2009 05:06:22 +0000 Subject: cluster/afr: Check op_ret in afr_getxattr_cbk before accessing dict Signed-off-by: Anand V. Avati BUG: 250 (Crash in replicate getxattr) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=250 --- xlators/cluster/afr/src/afr-inode-read.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'xlators/cluster/afr/src/afr-inode-read.c') diff --git a/xlators/cluster/afr/src/afr-inode-read.c b/xlators/cluster/afr/src/afr-inode-read.c index 2f9a6cda9fd..2032065119a 100644 --- a/xlators/cluster/afr/src/afr-inode-read.c +++ b/xlators/cluster/afr/src/afr-inode-read.c @@ -642,7 +642,8 @@ afr_getxattr_cbk (call_frame_t *frame, void *cookie, out: if (unwind) { - __filter_xattrs (dict); + if (op_ret >= 0 && dict) + __filter_xattrs (dict); AFR_STACK_UNWIND (frame, op_ret, op_errno, dict); } -- cgit