From d3c77459593255ed2c88094c8477b8a0c9ff9073 Mon Sep 17 00:00:00 2001 From: Atin Mukherjee Date: Thu, 31 Mar 2016 14:58:02 +0530 Subject: glusterd: build realpath post recreate of brick mount for snapshot Commit a60c39d introduced a new field called real_path in brickinfo to hold the realpath() conversion. However at restore path for all snapshots and snapshot restored volumes the brickpath gets recreated post restoration of bricks which means the realpath () call will fail here for all the snapshots and cloned volumes. Fix is to store the realpath for snapshots and clones post recreating the brick mounts. For normal volume it would be done during retrieving the brick details from the store. Change-Id: Ia34853acddb28bcb7f0f70ca85fabcf73276ef13 BUG: 1322772 Signed-off-by: Atin Mukherjee Reviewed-on: http://review.gluster.org/13869 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Avra Sengupta Reviewed-by: Rajesh Joseph Smoke: Gluster Build System --- .../bug-1322772-real-path-fix-for-snapshot.t | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 tests/bugs/snapshot/bug-1322772-real-path-fix-for-snapshot.t (limited to 'tests') diff --git a/tests/bugs/snapshot/bug-1322772-real-path-fix-for-snapshot.t b/tests/bugs/snapshot/bug-1322772-real-path-fix-for-snapshot.t new file mode 100644 index 00000000000..68dc0bbe0f7 --- /dev/null +++ b/tests/bugs/snapshot/bug-1322772-real-path-fix-for-snapshot.t @@ -0,0 +1,34 @@ +#!/bin/bash + +. $(dirname $0)/../../volume.rc +. $(dirname $0)/../../snapshot.rc +. $(dirname $0)/../../include.rc +cleanup; + +TEST verify_lvm_version +TEST init_n_bricks 1 +TEST setup_lvm 1 + +TEST glusterd +TEST pidof glusterd + +TEST $CLI volume create $V0 $H0:$L1 +EXPECT 'Created' volinfo_field $V0 'Status' + +TEST $CLI volume start $V0 +EXPECT 'Started' volinfo_field $V0 'Status' + +TEST $CLI snapshot create ${V0}_snap $V0 + +# Simulate a node reboot by unmounting the brick, snap_brick and followed by +# deleting the brick. Now once glusterd restarts, it should be able to construct +# and remount the snap brick +snap_brick=`gluster snap status | grep "Brick Path" | awk -F ":" '{print $3}'` + +pkill gluster +EXPECT_WITHIN $UMOUNT_TIMEOUT "Y" force_umount $L1 +EXPECT_WITHIN $UMOUNT_TIMEOUT "Y" force_umount $snap_brick +rm -rf $snap_brick + +TEST glusterd +TEST pidof glusterd -- cgit