From d27ecba4f8b453a6d4f2466a5583a8360a068a14 Mon Sep 17 00:00:00 2001 From: Emmanuel Dreyfus Date: Thu, 7 May 2015 16:45:53 +0200 Subject: Tests: use a portable way to flush kernel cache On Linux, kernel cache can be flushed using echo 3 > /proc/sys/vm/drop_caches This non-portable approach can be replaced by an on-purpose failed attempt to unmount: if the mount point is the current directory and umount is called, the kernel will flush inodes until it realize it cannot complete the operation because root of filesystem is busy: ( cd $M0 ; umount $M0 ) Unfortunately this does not flush everything. Entries may still be present in the kenrel FUSE cache. Using $GFS to mount the filesystem ensure --entry-timeout=0 and clears this problem. Some stall information may also remain in glusterfs caches, and that may have to be adressed by appropriate volume option. For instance tests/bugs/rpc/bug-954057.t needs to disable performance.stat-prefetch. Qtherwise, root's new credentials are not evaluated after root-quash is enabled. The test could also be done with performance.stat-prefetch enabled using various tricks: copying the file to read, creating a hard link on it, or just waiting long enough for metadata cache to expire. Backport of: I54929e899d55c04dcd9d947809133549f01fd0e1 BUG: 1212676 Signed-off-by: Emmanuel Dreyfus Change-Id: I2849a27acaa0334ef30aae3b852019b5a6eeb419 Reviewed-on: http://review.gluster.org/10648 Reviewed-by: Niels de Vos Tested-by: Gluster Build System Tested-by: NetBSD Build System --- tests/basic/tier/tier.t | 2 +- tests/bugs/glusterfs/bug-867253.t | 12 ++---------- tests/bugs/rpc/bug-954057.t | 21 ++++++++++++++++----- 3 files changed, 19 insertions(+), 16 deletions(-) (limited to 'tests') diff --git a/tests/basic/tier/tier.t b/tests/basic/tier/tier.t index d1e1041f87c..6097ad6e7d6 100755 --- a/tests/basic/tier/tier.t +++ b/tests/basic/tier/tier.t @@ -102,7 +102,7 @@ sleep 12 uuidgen >> d1/data2.txt # Check promotion on read to slow tier -echo 3 > /proc/sys/vm/drop_caches +( cd $M0 ; umount $M0 ) # fail but drops kernel cache cat d1/data3.txt sleep 5 EXPECT_WITHIN $PROMOTE_TIMEOUT "0" file_on_fast_tier d1/data2.txt diff --git a/tests/bugs/glusterfs/bug-867253.t b/tests/bugs/glusterfs/bug-867253.t index 3df49a1bd61..aee27c87158 100644 --- a/tests/bugs/glusterfs/bug-867253.t +++ b/tests/bugs/glusterfs/bug-867253.t @@ -4,14 +4,6 @@ . $(dirname $0)/../../volume.rc . $(dirname $0)/../../nfs.rc -# Skip the entire test if /proc/sys/vm/drop_caches does not exist -if [ ! -f /proc/sys/vm/drop_caches ] ; then - echo "Skip test using /proc/sys/vm/drop_caches, "\ - "which does not exists on this system" >&2 - SKIP_TESTS - exit 0 -fi - cleanup; function file_count() @@ -45,7 +37,7 @@ touch $M0/files{1..1000}; # Kill a brick process kill -9 `cat $GLUSTERD_WORKDIR/vols/$V0/run/$H0-d-backends-${V0}0.pid`; -echo 3 >/proc/sys/vm/drop_caches; +( cd $M0 ; umount $M0 ) # fail but drops kernel cache ls -l $M0 >/dev/null; @@ -56,7 +48,7 @@ TEST $CLI volume start $V0 force # Kill a brick process kill -9 `cat $GLUSTERD_WORKDIR/vols/$V0/run/$H0-d-backends-${V0}1.pid`; -echo 3 >/proc/sys/vm/drop_caches; +( cd $M0 ; umount $M0 ) ls -l $M0 >/dev/null; diff --git a/tests/bugs/rpc/bug-954057.t b/tests/bugs/rpc/bug-954057.t index 9c48207b711..faaf261d88b 100755 --- a/tests/bugs/rpc/bug-954057.t +++ b/tests/bugs/rpc/bug-954057.t @@ -3,15 +3,25 @@ . $(dirname $0)/../../include.rc . $(dirname $0)/../../volume.rc -#This script checks if use-readdirp option works as accepted in mount options - +# This script checks if use-readdirp option works as accepted in mount options + +# Note on re-reading $M0/new after enabling root-squash: +# Since we have readen it once, the file is present in various caches. +# In order to actually fail on second attempt we must: +# 1) drop kernel cache, by ( cd $M0 ; umount $M0 ) +# 2) make sure FUSE does not cache the entry. This is also +# in the kernel, but not flushed by a failed umount. +# Using $GFS enforces this because it sets --entry-timeout=0 +# 3) make sure reading new permissins does not produce stale +# information from glusterfs metadata cache. Setting volume +# option performance.stat-prefetch off enforces that. TEST glusterd TEST pidof glusterd TEST $CLI volume create $V0 $H0:$B0/${V0} TEST $CLI volume start $V0 -TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M0 +TEST $GFS --volfile-id=/$V0 --volfile-server=$H0 $M0 TEST mkdir $M0/dir TEST mkdir $M0/nobody @@ -21,8 +31,9 @@ TEST cp $M0/file $M0/new TEST chmod 700 $M0/new TEST cat $M0/new +TEST $CLI volume set $V0 performance.stat-prefetch off TEST $CLI volume set $V0 server.root-squash enable -TEST `echo 3 > /proc/sys/vm/drop_caches` +( cd $M0 ; umount $M0 ) # fails but drops kernel cache TEST ! mkdir $M0/other TEST mkdir $M0/nobody/other TEST cat $M0/file @@ -30,7 +41,7 @@ TEST ! cat $M0/new TEST `echo "nobody" >> $M0/nobody/file` #mount the client without root-squashing -TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 --no-root-squash=yes $M1 +TEST $GFS --volfile-id=/$V0 --volfile-server=$H0 --no-root-squash=yes $M1 TEST mkdir $M1/m1_dir TEST `echo "file" >> $M1/m1_file` TEST cp $M0/file $M1/new -- cgit