From 4cbb14cf6fc3f1b52ff0062a9fee88e2170ad454 Mon Sep 17 00:00:00 2001 From: Anand Avati Date: Tue, 29 Jan 2013 10:05:29 -0800 Subject: quick-read: various fixes - initialize xdata in qr_lookup even if it was NULL from top. This allows qr to do its job even if lookup originated from fuse-resolve.c - extend test cases to include 1 second delay and retry - fix bug while checking condition for cached unwind qr_readv_cached() unwinds if op_ret > 0. Therefore qr_readv() must wind to subvol only if !(op_ret > 0) (i.e, op_ret <= 0). - qr_readv_cached() is using uninitialized @conf pointer. Thanks to Raghavendra Bhat for catching this! Change-Id: Ifaf2ea2685e452210ef9ba3c2d1f2ab51900650c BUG: 846240 Signed-off-by: Anand Avati Reviewed-on: http://review.gluster.org/4452 Reviewed-by: Raghavendra Bhat Tested-by: Gluster Build System --- tests/performance/quick-read.t | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/performance/quick-read.t b/tests/performance/quick-read.t index 84bb7e66b3f..082998e4338 100644 --- a/tests/performance/quick-read.t +++ b/tests/performance/quick-read.t @@ -31,6 +31,16 @@ function write_to() TEST write_to "$M0/$F0" "$D0"; EXPECT "$D0" cat $M1/$F0; +EXPECT "$D0" cat $M0/$F0; +EXPECT "$D0" cat $M1/$F0; +EXPECT "$D0" cat $M0/$F0; + +sleep 1; + +EXPECT "$D0" cat $M1/$F0; +EXPECT "$D0" cat $M0/$F0; +EXPECT "$D0" cat $M1/$F0; +EXPECT "$D0" cat $M0/$F0; TEST $CLI volume set $V0 performance.quick-read off; @@ -38,7 +48,7 @@ D1="hello-this-is-a-test-message1"; F1="test-file1"; TEST write_to "$M0/$F1" "$D1"; -EXPECT "$D1" cat $M1/$F1; +EXPECT "$D1" cat $M0/$F1; EXPECT "$D0" cat $M1/$F0; -- cgit