From 499b43058049572e33b525ac669ef623d476fe41 Mon Sep 17 00:00:00 2001 From: N Balachandran Date: Fri, 30 Oct 2015 12:46:22 +0530 Subject: cluster/tier : Files skipped during tier query parsing The tier query parsing code was using fscanf to read each record. As space is a delimiter for fscanf, filenames containing spaces caused the parsing to return unexpected values causing various issues in the tier process, including crashes due to buffer overflows. Change-Id: Ife602cb7ecb158fccbc2c89e4d2959bd97098a87 BUG: 1276562 Signed-off-by: N Balachandran Reviewed-on: http://review.gluster.org/12469 Tested-by: NetBSD Build System Tested-by: Gluster Build System Reviewed-by: Dan Lambright Tested-by: Dan Lambright --- tests/tier.rc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'tests/tier.rc') diff --git a/tests/tier.rc b/tests/tier.rc index 393d712f3bb..3fa6af6a40f 100644 --- a/tests/tier.rc +++ b/tests/tier.rc @@ -18,6 +18,22 @@ function is_sticky_set () { } +function exists_and_regular_file () { + filepath=$1 + if [ -n "$filepath" ]; + then + if [ -k "$filepath" ] + then + echo "no" + else + echo "yes" + fi + else + echo "no" + fi +} + + function check_counters { index=0 ret=0 -- cgit