From 83778a592f75ef18ce5e22e14adc9bf118705a17 Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Wed, 10 Jun 2015 18:34:52 +0530 Subject: afr: allow readdir to proceed for directories in split-brain Problem: afr_read_txn() bails out if read_subvol==-1. This meant that for directories that were in entry split-brain, FOPS like readdir, access, stat etc were not allowed. Fix: Except for getxattr, all other FOPS are wound on the first up child of afr. Change-Id: Iacec8fbb1e75c4d2094baa304f62331c81a6f670 BUG: 1230242 Signed-off-by: Ravishankar N Reviewed-on: http://review.gluster.org/10776 Reviewed-by: Pranith Kumar Karampuri Reviewed-by: Anuradha Talur (cherry picked from commit 49b428433a03fcf709fdc8c08603b4cf02198e0a) Signed-off-by: Ravishankar N Reviewed-on: http://review.gluster.org/11162 Tested-by: Gluster Build System Reviewed-by: Raghavendra Bhat --- .../bug-1221481-allow-fops-on-dir-split-brain.t | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 tests/bugs/replicate/bug-1221481-allow-fops-on-dir-split-brain.t (limited to 'tests/bugs/replicate/bug-1221481-allow-fops-on-dir-split-brain.t') diff --git a/tests/bugs/replicate/bug-1221481-allow-fops-on-dir-split-brain.t b/tests/bugs/replicate/bug-1221481-allow-fops-on-dir-split-brain.t new file mode 100644 index 00000000000..cd4a9bad87b --- /dev/null +++ b/tests/bugs/replicate/bug-1221481-allow-fops-on-dir-split-brain.t @@ -0,0 +1,37 @@ +#!/bin/bash +. $(dirname $0)/../../include.rc +. $(dirname $0)/../../volume.rc +. $(dirname $0)/../../afr.rc +cleanup; + +#Allow readdirs to proceed on directories that are in split-brain + +TEST glusterd; +TEST pidof glusterd; +TEST $CLI volume create $V0 replica 2 $H0:$B0/${V0}{0,1}; +TEST $CLI volume set $V0 cluster.self-heal-daemon off +TEST $CLI volume start $V0; +TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M0 --attribute-timeout=0 --entry-timeout=0 +TEST mkdir $M0/dir +TEST touch $M0/dir/file{1..5} + +#Create metadata and entry split-brain +TEST kill_brick $V0 $H0 $B0/$V0"1" +TEST setfattr -n user.attribute -v value1 $M0/dir +TEST touch $M0/dir/FILE +TEST $CLI volume start $V0 force +EXPECT_WITHIN $CHILD_UP_TIMEOUT '1' afr_child_up_status_meta $M0 $V0-replicate-0 1 +TEST kill_brick $V0 $H0 $B0/$V0"0" +TEST setfattr -n user.attribute -v value2 $M0/dir +TEST touch $M0/dir/FILE +TEST $CLI volume start $V0 force +EXPECT_WITHIN $CHILD_UP_TIMEOUT '1' afr_child_up_status_meta $M0 $V0-replicate-0 0 + +TEST ! getfattr $M0/dir +cd $M0/dir +EXPECT "6" echo $(ls | wc -l) +TEST ! cat FILE +TEST `echo hello>hello.txt` +cd - +TEST umount $M0 +cleanup -- cgit