From 6e27b9744f89430d4a33b36f96a78d7b048b16ff Mon Sep 17 00:00:00 2001 From: Mohammed Rafi KC Date: Tue, 28 Apr 2015 19:17:40 +0530 Subject: tiering/cli: Check replica count and bricks are proper or not Back port of http://review.gluster.org/10428 Right now, attach-tier calls parsing function for add-brick. Add-brick does not have any check for brick count and replca count compatibility. >Change-Id: I44ec13eadffc003a9ebf8c4eb0193df559933a68 >BUG: 1215122 >Signed-off-by: Mohammed Rafi KC >Reviewed-on: http://review.gluster.org/10428 >Reviewed-by: Dan Lambright >Tested-by: Gluster Build System >Reviewed-by: Vijay Bellur Change-Id: Ie86d5b61b044386a062bfc9782178853e3af0f11 BUG: 1219850 Signed-off-by: Mohammed Rafi KC Reviewed-on: http://review.gluster.org/10710 Reviewed-by: Dan Lambright Tested-by: Gluster Build System --- tests/basic/tier/tier.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests/basic') diff --git a/tests/basic/tier/tier.t b/tests/basic/tier/tier.t index 81abc5779ab..8e72071af1a 100755 --- a/tests/basic/tier/tier.t +++ b/tests/basic/tier/tier.t @@ -59,11 +59,12 @@ PROMOTE_TIMEOUT=5 MIGRATION_TIMEOUT=10 cleanup - TEST glusterd TEST pidof glusterd TEST $CLI volume create $V0 replica 2 $H0:$B0/${V0}{0..$LAST_BRICK} +# testing bug 1215122, ie should fail if replica count and bricks are not compatible. +TEST ! $CLI volume attach-tier $V0 replica 5 $H0:$B0/${V0}$CACHE_BRICK_FIRST $H0:$B0/${V0}$CACHE_BRICK_LAST TEST $CLI volume attach-tier $V0 replica 2 $H0:$B0/${V0}$CACHE_BRICK_FIRST $H0:$B0/${V0}$CACHE_BRICK_LAST TEST $CLI volume start $V0 TEST $CLI volume set $V0 features.ctr-enabled on -- cgit