From 89125a3618660522787b570f030b40d798e0c99b Mon Sep 17 00:00:00 2001 From: Krishnan Parthasarathi Date: Mon, 30 Jun 2014 11:26:54 +0530 Subject: socket: reduce rate of readv failure logs due to disconnect Backport of http://review.gluster.org/8210 ... by using GF_LOG_OCCASIONALLY Change-Id: I779ff32ead13c8bb446a57b5baccf068ae992df1 BUG: 1310969 Signed-off-by: Krishnan Parthasarathi Reviewed-on: http://review.gluster.org/8210 Tested-by: Atin Mukherjee Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Raghavendra G Reviewed-on: http://review.gluster.org/13487 --- rpc/rpc-transport/socket/src/socket.c | 11 ++++++----- rpc/rpc-transport/socket/src/socket.h | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) (limited to 'rpc') diff --git a/rpc/rpc-transport/socket/src/socket.c b/rpc/rpc-transport/socket/src/socket.c index b3a80d9ceb1..21256bb15ca 100644 --- a/rpc/rpc-transport/socket/src/socket.c +++ b/rpc/rpc-transport/socket/src/socket.c @@ -581,11 +581,12 @@ __socket_rwv (rpc_transport_t *this, struct iovec *vector, int count, if (__does_socket_rwv_error_need_logging (priv, write)) { - gf_log (this->name, GF_LOG_WARNING, - "%s on %s failed (%s)", - write ? "writev":"readv", - this->peerinfo.identifier, - strerror (errno)); + GF_LOG_OCCASIONALLY(priv->log_ctr, this->name, + GF_LOG_WARNING, + "%s on %s failed (%s)", + write ? "writev":"readv", + this->peerinfo.identifier, + strerror (errno)); } if (priv->use_ssl && priv->ssl_ssl) { diff --git a/rpc/rpc-transport/socket/src/socket.h b/rpc/rpc-transport/socket/src/socket.h index c4d27e21947..8732ca919c6 100644 --- a/rpc/rpc-transport/socket/src/socket.h +++ b/rpc/rpc-transport/socket/src/socket.h @@ -245,6 +245,7 @@ typedef struct { ot_state_t ot_state; uint32_t ot_gen; gf_boolean_t is_server; + int log_ctr; } socket_private_t; -- cgit