From 730f520a1ee246a5f4a08a321b6f97bdf93536dc Mon Sep 17 00:00:00 2001
From: Michael Scherer <misc@redhat.com>
Date: Wed, 22 Feb 2017 17:58:24 +0100
Subject: Free iobuf after using it, not before

Coverity warn of use after free here. I assume that
under pressure, this might crash the whole process.

Change-Id: I15fb5cfc9b509705e96e4156b739988d816bbef5
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16719
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
---
 rpc/rpc-transport/socket/src/socket.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'rpc')

diff --git a/rpc/rpc-transport/socket/src/socket.c b/rpc/rpc-transport/socket/src/socket.c
index 09020aa68ae..c7907832e3c 100644
--- a/rpc/rpc-transport/socket/src/socket.c
+++ b/rpc/rpc-transport/socket/src/socket.c
@@ -1438,11 +1438,11 @@ sp_state_read_proghdr_xdata:
                         }
 
                         iobref_add (in->iobref, iobuf);
-                        iobuf_unref (iobuf);
 
                         in->payload_vector.iov_base = iobuf_ptr (iobuf);
-
                         frag->fragcurrent = iobuf_ptr (iobuf);
+
+                        iobuf_unref (iobuf);
                 }
 
                 request->vector_state = SP_STATE_READING_PROG;
-- 
cgit