From 2bf85951c6c25aa17acc591fabc3b3927b6dc82f Mon Sep 17 00:00:00 2001 From: Soumya Koduri Date: Mon, 30 Mar 2015 16:56:59 +0530 Subject: Upcall: Process each of the upcall events separately As suggested during the code-review of Bug1200262, have modified GF_CBK_UPCALL to be exlusively GF_CBK_CACHE_INVALIDATION. Thus, for any new upcall event, a new CBK procedure will be added. Also made changes to store upcall data separately based on the upcall event type received. BUG: 1200262 Change-Id: I0f5e53d6f5ece16aecb514a0a426dca40fa1c755 Signed-off-by: Soumya Koduri Reviewed-on: http://review.gluster.org/10049 Tested-by: Gluster Build System Reviewed-by: Kaleb KEITHLEY --- rpc/xdr/src/glusterfs3.h | 54 ++++++++++++++++++++++++++++++++++-------------- 1 file changed, 38 insertions(+), 16 deletions(-) (limited to 'rpc/xdr/src/glusterfs3.h') diff --git a/rpc/xdr/src/glusterfs3.h b/rpc/xdr/src/glusterfs3.h index c2fa15f9e79..2acdfc756c4 100644 --- a/rpc/xdr/src/glusterfs3.h +++ b/rpc/xdr/src/glusterfs3.h @@ -268,28 +268,50 @@ gf_stat_from_iatt (struct gf_iatt *gf_stat, struct iatt *iatt) } static inline void -gf_proto_upcall_from_upcall (gfs3_upcall_req *gf_up_req, - struct gf_upcall *gf_up_data) +gf_proto_cache_invalidation_from_upcall (gfs3_cbk_cache_invalidation_req *gf_c_req, + struct gf_upcall *gf_up_data) { - if (!gf_up_req || !gf_up_data) - return; + struct gf_upcall_cache_invalidation *gf_c_data = NULL; + int is_cache_inval = 0; + + GF_VALIDATE_OR_GOTO(THIS->name, gf_c_req, out); + GF_VALIDATE_OR_GOTO(THIS->name, gf_up_data, out); + + is_cache_inval = ((gf_up_data->event_type == + GF_UPCALL_CACHE_INVALIDATION) ? 1 : 0); + GF_VALIDATE_OR_GOTO(THIS->name, is_cache_inval, out); + + gf_c_data = (struct gf_upcall_cache_invalidation *)gf_up_data->data; + GF_VALIDATE_OR_GOTO(THIS->name, gf_c_data, out); + + memcpy (gf_c_req->gfid, gf_up_data->gfid, 16); + gf_c_req->event_type = gf_up_data->event_type; + gf_c_req->flags = gf_c_data->flags; + gf_c_req->expire_time_attr = gf_c_data->expire_time_attr; - memcpy (gf_up_req->gfid, gf_up_data->gfid, 16); - gf_up_req->event_type = gf_up_data->event_type; - gf_up_req->flags = gf_up_data->flags; - gf_up_req->expire_time_attr = gf_up_data->expire_time_attr; +out: + return; } static inline void -gf_proto_upcall_to_upcall (gfs3_upcall_req *gf_up_req, - struct gf_upcall *gf_up_data) +gf_proto_cache_invalidation_to_upcall (gfs3_cbk_cache_invalidation_req *gf_c_req, + struct gf_upcall *gf_up_data) { - if (!gf_up_req || !gf_up_data) - return; + struct gf_upcall_cache_invalidation *gf_c_data = NULL; + + GF_VALIDATE_OR_GOTO(THIS->name, gf_c_req, out); + GF_VALIDATE_OR_GOTO(THIS->name, gf_up_data, out); + + gf_c_data = (struct gf_upcall_cache_invalidation *)gf_up_data->data; + GF_VALIDATE_OR_GOTO(THIS->name, gf_c_data, out); + + memcpy (gf_up_data->gfid, gf_c_req->gfid, 16); + gf_up_data->event_type = gf_c_req->event_type; + + gf_c_data->flags = gf_c_req->flags; + gf_c_data->expire_time_attr = gf_c_req->expire_time_attr; - memcpy (gf_up_data->gfid, gf_up_req->gfid, 16); - gf_up_data->event_type = gf_up_req->event_type; - gf_up_data->flags = gf_up_req->flags; - gf_up_data->expire_time_attr = gf_up_req->expire_time_attr; +out: + return; } #endif /* !_GLUSTERFS3_H */ -- cgit