From cd95c072f4bc13c5c920aae359e8e9b84725ea2c Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Tue, 21 Aug 2018 23:34:52 +0300 Subject: rpc/rpc-lib/src/rpc-clnt-ping.c:move to GF_MALLOC() instead of GF_CALLOC() when It doesn't make sense to calloc (allocate and clear) memory when the code right away fills that memory with data. It may be optimized by the compiler, or have a microscopic performance improvement. Please review carefully, especially for string allocation, with the terminating NULL string. Only compile-tested! Change-Id: Ifb30412ddf1bfa509f52e0454454929b266e5658 updates: bz#1193929 Signed-off-by: Yaniv Kaul --- rpc/rpc-lib/src/rpc-clnt-ping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'rpc/rpc-lib') diff --git a/rpc/rpc-lib/src/rpc-clnt-ping.c b/rpc/rpc-lib/src/rpc-clnt-ping.c index af4a993476e..25629891379 100644 --- a/rpc/rpc-lib/src/rpc-clnt-ping.c +++ b/rpc/rpc-lib/src/rpc-clnt-ping.c @@ -266,7 +266,7 @@ rpc_clnt_ping (struct rpc_clnt *rpc) struct ping_local *local = NULL; conn = &rpc->conn; - local = GF_CALLOC (1, sizeof(struct ping_local), + local = GF_MALLOC (sizeof(struct ping_local), gf_common_ping_local_t); if (!local) return ret; -- cgit