From cbe133c832fd9907619a1231aa3d9dda1330ae74 Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Fri, 24 Aug 2018 20:59:30 +0300 Subject: multiple files: remove unndeeded memset() This is a squash of multiple commits: contrib/fuse-lib/misc.c: remove unneeded memset() All flock variables are properly set, no need to memset it. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: I8e0512c5a88daadb0e587f545fdb9b32ca8858a2 libglusterfs/src/{client_t|fd|inode|stack}.c: remove some memset() I don't think there's a need for any of them. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: I2be9ccc3a5cb5da51a92af73488cdabd1c527f59 libglusterfs/src/xlator.c: remove unneeded memset() All xl->mem_acct members are properly set, no need to memset it. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: I7f264cd47e7a06255a3f3943c583de77ae8e3147 xlators/cluster/afr/src/afr-self-heal-common.c: remove unneeded memset() Since we are going over the whole array anyway, initialize it properly, to either 1 or 0. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: Ied4210388976b6a7a2e91cc3de334534d6fef201 xlators/cluster/dht/src/dht-common.c: remove unneeded memset() Since we are going over the whole array anyway it is initialized properly. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: Idc436d2bd0563b6582908d7cbebf9dbc66a42c9a xlators/cluster/ec/src/ec-helpers.c: remove unneeded memset() Since we are going over the whole array anyway it is initialized properly. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: I81bf971f7fcecb4599e807d37f426f55711978fa xlators/mgmt/glusterd/src/glusterd-volgen.c: remove some memset() I don't think there's a need for any of them. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: I476ea59ba53546b5153c269692cd5383da81ce2d xlators/mgmt/glusterd/src/glusterd-geo-rep.c: read() in 4K blocks The current 1K seems small. 4K is usually better (in Linux). Also remove a memset() that I don't think is needed between reads. Only compile-tested! Signed-off-by: Yaniv Kaul Change-Id: I5fb7950c92d282948376db14919ad12e589eac2b xlators/storage/posix/src/posix-{gfid-path|inode-fd-ops}.c: remove memset() before sys_*xattr() functions. I don't see a reason to memset the array sent to the functions sys_llistxattr(), sys_lgetxattr(), sys_lgetxattr(), sys_flistxattr(), sys_fgetxattr(). (Note: it's unclear to me why we are calling sys_*txattr() functions with XATTR_VAL_BUF_SIZE-1 size instead of XATTR_VAL_BUF_SIZE ). Only compile-tested! Change-Id: Ief2103b56ba6c71e40ed343a93684eef6b771346 updates: bz#1193929 Signed-off-by: Yaniv Kaul --- libglusterfs/src/client_t.c | 6 ------ libglusterfs/src/fd.c | 2 -- libglusterfs/src/inode.c | 2 -- libglusterfs/src/stack.c | 1 - libglusterfs/src/xlator.c | 1 - 5 files changed, 12 deletions(-) (limited to 'libglusterfs') diff --git a/libglusterfs/src/client_t.c b/libglusterfs/src/client_t.c index eb9e7a78b22..844acbc459c 100644 --- a/libglusterfs/src/client_t.c +++ b/libglusterfs/src/client_t.c @@ -598,12 +598,9 @@ client_ctx_del (client_t *client, void *key, void **value) void client_dump (client_t *client, char *prefix) { - char key[GF_DUMP_MAX_BUF_LEN]; - if (!client) return; - memset(key, 0, sizeof key); gf_proc_dump_write("refcount", GF_PRI_ATOMIC, GF_ATOMIC_GET (client->count)); } @@ -641,7 +638,6 @@ clienttable_dump (clienttable_t *clienttable, char *prefix) "Unable to acquire lock"); return; } - memset(key, 0, sizeof key); gf_proc_dump_build_key(key, prefix, "maxclients"); gf_proc_dump_write(key, "%d", clienttable->max_clients); gf_proc_dump_build_key(key, prefix, "first_free"); @@ -792,7 +788,6 @@ gf_client_dump_fdtables (xlator_t *this) clienttable->cliententries[count].next_free) continue; client = clienttable->cliententries[count].client; - memset(key, 0, sizeof key); if (client->client_uid) { gf_proc_dump_build_key (key, "conn", "%d.id", count); @@ -929,7 +924,6 @@ gf_client_dump_inodes (xlator_t *this) clienttable->cliententries[count].next_free) continue; client = clienttable->cliententries[count].client; - memset(key, 0, sizeof key); if (client->bound_xl && client->bound_xl->itable) { /* Presently every brick contains only * one bound_xl for all connections. diff --git a/libglusterfs/src/fd.c b/libglusterfs/src/fd.c index 01e292cc107..ee14dc8fe43 100644 --- a/libglusterfs/src/fd.c +++ b/libglusterfs/src/fd.c @@ -1032,7 +1032,6 @@ fd_dump (fd_t *fd, char *prefix) if (!fd) return; - memset(key, 0, sizeof(key)); gf_proc_dump_write("pid", "%llu", fd->pid); gf_proc_dump_write("refcount", "%d", fd->refcount); gf_proc_dump_write("flags", "%d", fd->flags); @@ -1074,7 +1073,6 @@ fdtable_dump (fdtable_t *fdtable, char *prefix) if (ret) goto out; - memset(key, 0, sizeof(key)); gf_proc_dump_build_key(key, prefix, "refcount"); gf_proc_dump_write(key, "%d", fdtable->refcount); gf_proc_dump_build_key(key, prefix, "maxfds"); diff --git a/libglusterfs/src/inode.c b/libglusterfs/src/inode.c index 11814d52d7c..70909bf596f 100644 --- a/libglusterfs/src/inode.c +++ b/libglusterfs/src/inode.c @@ -2331,7 +2331,6 @@ inode_dump (inode_t *inode, char *prefix) if (!inode) return; - memset(key, 0, sizeof(key)); INIT_LIST_HEAD (&fd_list); ret = TRY_LOCK(&inode->lock); @@ -2406,7 +2405,6 @@ inode_table_dump (inode_table_t *itable, char *prefix) if (!itable) return; - memset(key, 0, sizeof(key)); ret = pthread_mutex_trylock(&itable->lock); if (ret != 0) { diff --git a/libglusterfs/src/stack.c b/libglusterfs/src/stack.c index 13107e4e3bc..2987441bb6d 100644 --- a/libglusterfs/src/stack.c +++ b/libglusterfs/src/stack.c @@ -97,7 +97,6 @@ gf_proc_dump_call_frame (call_frame_t *call_frame, const char *key_buf,...) GF_ASSERT (key_buf); - memset(&my_frame, 0, sizeof(my_frame)); va_start(ap, key_buf); vsnprintf(prefix, GF_DUMP_MAX_BUF_LEN, key_buf, ap); va_end(ap); diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index cd71d5fe384..22e3e041fd9 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -812,7 +812,6 @@ xlator_mem_acct_init (xlator_t *xl, int num_types) if (!xl->mem_acct) { return -1; } - memset (xl->mem_acct, 0, sizeof(struct mem_acct)); xl->mem_acct->num_types = num_types; GF_ATOMIC_INIT (xl->mem_acct->refcnt, 1); -- cgit