From b65f54c9aa1e3405b731769e56460592ba69ed60 Mon Sep 17 00:00:00 2001 From: Pavan T C Date: Mon, 28 Mar 2011 03:50:29 +0000 Subject: Loosen restrictions on hostnames Signed-off-by: Pavan T C Signed-off-by: Vijay Bellur BUG: 2249 (Problems with hostname validation) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2249 --- libglusterfs/src/xlator.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) (limited to 'libglusterfs/src') diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index b9952120ddb..b18641449ee 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -619,10 +619,8 @@ _volume_option_value_validate_attacherr (xlator_t *xl, break; case GF_OPTION_TYPE_INTERNET_ADDRESS: { - if (valid_internet_address (pair->value->data)) { - ret = 0; - } else { - gf_log (xl->name, GF_LOG_ERROR, "internet address '%s'" + if (!valid_internet_address (pair->value->data)) { + gf_log (xl->name, GF_LOG_WARNING, "internet address '%s'" " does not conform to standards.", pair->value->data); @@ -632,8 +630,8 @@ _volume_option_value_validate_attacherr (xlator_t *xl, pair->value->data); *op_errstr = gf_strdup (errstr); - goto out; } + ret = 0; } break; case GF_OPTION_TYPE_ANY: @@ -1019,14 +1017,12 @@ _volume_option_value_validate (xlator_t *xl, break; case GF_OPTION_TYPE_INTERNET_ADDRESS: { - if (valid_internet_address (pair->value->data)) { - ret = 0; - } else { - gf_log (xl->name, GF_LOG_ERROR, "internet address '%s'" + if (!valid_internet_address (pair->value->data)) { + gf_log (xl->name, GF_LOG_WARNING, "internet address '%s'" " does not conform to standards.", pair->value->data); - goto out; } + ret = 0; } break; case GF_OPTION_TYPE_ANY: -- cgit