From b41cdeb638f9f9ec2fef13ec95c216faf52a9df9 Mon Sep 17 00:00:00 2001 From: Mohit Agrawal Date: Mon, 28 Jan 2019 21:28:45 +0530 Subject: core: heketi-cli is throwing error "target is busy" Problem: When rpc-transport-disconnect happens, server_connection_cleanup_flush_cbk() is supposed to call rpc_transport_unref() after open-files on that transport are flushed per transport.But open-fd-count is maintained in bound_xl->fd_count, which can be incremented/decremented cumulatively in server_connection_cleanup() by all transport disconnect paths. So instead of rpc_transport_unref() happening per transport, it ends up doing it only once after all the files on all the transports for the brick are flushed leading to rpc-leaks. Solution: To avoid races maintain fd_cnt at client instead of maintaining on brick Credits: Pranith Kumar Karampuri Change-Id: I6e8ea37a61f82d9aefb227c5b3ab57a7a36850e6 fixes: bz#1668190 Signed-off-by: Mohit Agrawal --- libglusterfs/src/xlator.c | 1 - 1 file changed, 1 deletion(-) (limited to 'libglusterfs/src/xlator.c') diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index bd568660863..dc1e88770fb 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -614,7 +614,6 @@ xlator_init(xlator_t *xl) xl->instance_name = NULL; GF_ATOMIC_INIT(xl->xprtrefcnt, 0); - GF_ATOMIC_INIT(xl->fd_cnt, 0); if (!xl->init) { gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_INIT_FAILED, "No init() found"); -- cgit