From 8383a5163d0b97105e600e9361d322882023295f Mon Sep 17 00:00:00 2001 From: Xavier Hernandez Date: Thu, 9 Jun 2016 17:29:26 +0200 Subject: cluster/ec: Fix invalid __fd_unref() call __fd_unref() doesn't do any cleanup, so it cannot be called to release fd references, specially if it's the last reference. The code has been changed to avoid a call to this function. In the previous version we always tried to keep the newest fd in the ec_lock_t structure. However this is not necessary. We'll always keep one reference to an open file on the same inode. It's irrelevant if the reference is new or old. The function __fd_unref() has also been removed from fd.h to avoid being used in the future since it's useless as it's defined now. Backport of http://review.gluster.org/14683 Change-Id: Ia728777fc8e464758d5ea4d3bf020f0603919039 BUG: 1344422 Signed-off-by: Xavier Hernandez Reviewed-on: http://review.gluster.org/14685 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Pranith Kumar Karampuri --- libglusterfs/src/fd.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'libglusterfs/src/fd.h') diff --git a/libglusterfs/src/fd.h b/libglusterfs/src/fd.h index 2e93f76988a..f4a8c444198 100644 --- a/libglusterfs/src/fd.h +++ b/libglusterfs/src/fd.h @@ -121,9 +121,6 @@ fd_t * fd_ref (fd_t *fd); -fd_t * -__fd_unref (fd_t *fd); - void fd_unref (fd_t *fd); -- cgit